-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random seed split #4842
Random seed split #4842
Conversation
@joaorobson is this still a draft PR or is it ready for review? |
5c91e2b
to
6bc5d3e
Compare
It is ready now. I just needed to update the docs and the changelog. |
6bc5d3e
to
8d2fd7d
Compare
Ok, we'll give it a review as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀 Just a few comments. Thanks for adding a test!
Please, update your branch and update the changelog entry (https://github.com/RasaHQ/rasa/tree/master/changelog).
c5067e8
to
c6bd407
Compare
Thanks. I guess that I've fixed everything that you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 🎉
Proposed changes:
Expected behavior:
rasa data split nlu --random-seed=42
Status (please check what you already did):
black
(please check Readme for instructions)