Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match latest getting started flow (discussion) #338

Merged
merged 103 commits into from
Nov 13, 2019
Merged

Conversation

msamogh
Copy link
Contributor

@msamogh msamogh commented Sep 18, 2019

Steps Merger

  • Steps 2 and 4 have been coalesced into step 2 now
  • Refactor template and intent names accordingly
  • Refactor story files to match that
  • Remove any references to the extra step from FAQ and Chitchat story files

Installation flow

  • Python installation is already built-in to the installation page
  • Sara will simply link to the detailed instructions if user is either new or is facing issues with installation

@msamogh msamogh requested a review from akelad October 14, 2019 17:29
- buttons:
- payload: /get_started_step2
title: Continue
text: Let's continue, click the button below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msamogh did you take a look at the utterances on website-demo.rasa.com to define channel specific templates here? Because like i said these are different for hte socketio channel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by "channel-specific templates" @akelad

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you take a look at the utterances on the instance i'm talking about? They're different to what is defined here, because we do some redirecting to pages when the user clicks a button.
This is what i mean: https://rasa.com/docs/rasa/core/domains/#channel-specific-utterances

@akelad
Copy link
Contributor

akelad commented Nov 10, 2019

@erohmensing what's left to be done apart from the utterances from website-demo? Imo we can merge this if that's the only thing holding this up

@erohmensing
Copy link
Contributor

Sorry, i didn't see your comment. i agree, let's get this merges and then we can add the website demo utterances after

@erohmensing erohmensing requested a review from akelad November 12, 2019 16:18
@erohmensing
Copy link
Contributor

Ready for a merge review mayhaps

@akelad akelad merged commit 2364e07 into master Nov 13, 2019
@erohmensing erohmensing deleted the new-new-getting-started branch January 1, 2020 12:53
hamzaziizzz pushed a commit to hamzaziizzz/rasa-demo that referenced this pull request Aug 10, 2024
Match latest getting started flow (discussion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants