Add support leaflet for v1.9.3 #21
Conversation
Compare latest changes from: Leaflet/Leaflet@v1.7.0...v1.9.3
src/layer/marker/Marker.js
Outdated
| // paddingBottomRight: size.subtract(anchor) | ||
| // }); | ||
| }, | ||
|
|
There was a problem hiding this comment.
@siimaoo the reason behind that bug should be this new feature marker-autopanonfocus (added by leaflet v1.8).
For the moment I have disabled it, could you help me in trying to re-enable it?
If you take a quick look to the rest of this plugin code in general it's just about "adding" a rotation function (to a point or bounds calculation) among those already present in this library, the difficult thing is enough time right to find the right one..
Ref: #18
There was a problem hiding this comment.
tonight (gmt -3) I'll take a look at this
test/index.html
Outdated
| <!-- Leaflet-MarkerCluster --> | ||
| <script src="https://unpkg.com/[email protected]/dist/leaflet.markercluster-src.js"></script> | ||
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/MarkerCluster.css"> | ||
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/MarkerCluster.Default.css"> | ||
|
|
There was a problem hiding this comment.
@siimaoo for your tests, here is a complete example of integration with leaflet v1.9 and leaflet.markercluster
There was a problem hiding this comment.
cluster.bug.mp4
the bug persist!
00:00 - 00:30 - everything ok
00:30 - 00:45 - bug
There was a problem hiding this comment.
@siimaoo are you sure you're not running your tests on the wrong file? (ie: examples/index.html instead of test/index.html)
The code of the leaflet-v1.9.3 branch should also show you some other info about the pixel bounds (a red-dotted rectangle in the map and a related table row, like the picture shown here #18 (comment))
There was a problem hiding this comment.
@Raruto sorry, I running the test on the wrong file! Now, everything is good!
There was a problem hiding this comment.
Is working with cluster, draggable markers and popups! Nice!
…autoPanOnFocus` option Ref: - https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/map/Map.js#L517-L538 - https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/map/Map.js#L903-L906 - https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/layer/marker/Marker.js#L389-L401 - https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/layer/marker/Marker.js#L84
|
|
||
| // @option bounceAtZoomLimits: Boolean = true | ||
| // Set it to false if you don't want the map to zoom beyond min/max zoom | ||
| // and then bounce back when pinch-zooming. | ||
| bounceAtZoomLimits: false, |
There was a problem hiding this comment.
@heyajohnny looks so much like a duplicate of:
BTW, could be related to #19? (eg. due to current incorrect map bounds calculations, ref: #18 (comment))
There was a problem hiding this comment.
Yes it's a duplicate of 'TouchGestures.js' and this one (in 'TouchZoom.js') can be removed.
I've tested it with these combinations:
- touchGestures: true, touchZoom: false
- touchGestures: false, touchZoom: true
- touchGestures: true, touchZoom: true
And it works as expected without this 'bounceAtZoomLimits: false,'.
| @@ -63,7 +63,7 @@ L.Map.TouchGestures = L.Handler.extend({ | |||
|
|
|||
| this._moved = false; | |||
|
|
|||
| map.stop(); | |||
| map._stop(); | |||
There was a problem hiding this comment.
@heyajohnny did you happen to find the original source of the L.Map.TouchGestures.js handler ? (I could be wrong, but I don't think I developed it), although I don't think there's anything like it in here:
I'm just asking because it seems strange that a different method has been used here before than the original implementation (ie map.stop() instead of map._stop(), ref: fnicollet/Leaflet/src/map/handler/Map.TouchZoom.js#L52)
There was a problem hiding this comment.
No, Your first version contained the map.stop(), but all the other current handlers have the map._stop(), so I guessed it was either a typo or an old method that changed name.
There was a problem hiding this comment.
@heyajohnny If it helps, this is the commit where it was initially added: fnicollet/Leaflet@a77af51
🤦♂️ I couldn't find it because I was looking in the wrong branch.. (master instead of rotate-master).
I had also written it in the readme file:
Side notes:
Be aware that this is a proof of concept that shows how to alter the core leaflet library and make rotation feature usable as a standalone plugin. Check out fnicollet's rotate-master branch if you prefer to use a reliable all-in-one solution.
Latest changes to this project have been updated comparing on the following: Leaflet/Leaflet@main...fnicollet:rotate-master (ref: bac6c7d)
internally replace `this.getPixelBounds()` call with `this._container.getBoundingClientRect()` for determing outer map container pixel coordinates
Compare latest changes from: Leaflet/Leaflet@v1.7.0...v1.9.3