Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread guide #7496

Open
wants to merge 26 commits into
base: docs/guide
Choose a base branch
from
Open

Conversation

AbstractUmbra
Copy link
Contributor

@AbstractUmbra AbstractUmbra commented Mar 6, 2022

Summary

This PR adds a section on the guide for threads.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@AbstractUmbra AbstractUmbra changed the title Docs/threads docs Thread guide Mar 6, 2022
@Rapptz Rapptz added the guide This relates to the discord.py guide label Mar 9, 2022
@Rapptz Rapptz mentioned this pull request Mar 12, 2022
23 tasks
Copy link
Contributor

@scarletcafe scarletcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already reviewed and revised this one so I think it's good, RFC from others I guess.

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly fine, but can we add a section about how to deal with threads when you receive a message from them.

Copy link
Contributor

@Soheab Soheab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a section or should mention something about forum channels, "posts" and tags (get, create, add).

@AbstractUmbra
Copy link
Contributor Author

This is mostly fine, but can we add a section about how to deal with threads when you receive a message from them.

Started on this but needs more fleshing out. Having a bit of issues trying to think of gotchas relating to this to add in. Suggestions on this are very welcome!

Copy link
Contributor

@tailoric tailoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One inaccuracy about public threads in the guide.
  • Otherwise some nitpicks and corrections to the wording.
  • Two small wishes to expand on some examples.

Overall I'd say however the guide is pretty far and well written and should give a complete overview over the capabilities of threads (unless I missed something)

Copy link
Contributor

@Soheab Soheab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small things, looks good and has everything relevant otherwise.

@AbstractUmbra AbstractUmbra requested a review from Soheab January 31, 2024 19:05
Copy link
Contributor

@tailoric tailoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything to fix or add right now so
LGTM

@No767
Copy link

No767 commented Jan 31, 2024

I will review this sometime this week for my input

Copy link

@No767 No767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my thoughts below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guide This relates to the discord.py guide
Projects
Status: Ready for final review
Development

Successfully merging this pull request may close these issues.

8 participants