-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread guide #7496
base: docs/guide
Are you sure you want to change the base?
Thread guide #7496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already reviewed and revised this one so I think it's good, RFC from others I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly fine, but can we add a section about how to deal with threads when you receive a message from them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a section or should mention something about forum channels, "posts" and tags (get, create, add).
1e2c7e9
to
f163c25
Compare
f163c25
to
7d04287
Compare
Started on this but needs more fleshing out. Having a bit of issues trying to think of gotchas relating to this to add in. Suggestions on this are very welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- One inaccuracy about public threads in the guide.
- Otherwise some nitpicks and corrections to the wording.
- Two small wishes to expand on some examples.
Overall I'd say however the guide is pretty far and well written and should give a complete overview over the capabilities of threads (unless I missed something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small things, looks good and has everything relevant otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything to fix or add right now so
LGTM
I will review this sometime this week for my input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left my thoughts below
Summary
This PR adds a section on the guide for threads.
Checklist