Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'mention' property in PartialWebhookChannel #10101

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

Gooraeng
Copy link
Contributor

@Gooraeng Gooraeng commented Feb 8, 2025

Summary

I was trying to make a function to follow channel(s) and found PartialWebhookChannel can be set when source_channel is not None. So this means source_channel_id also would not be None. So I would like to suggest to add mention property for this.

I hope you'll review it positively. Thank you.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset seems fine but you need to run black to pass CI.

Thanks.

@Gooraeng Gooraeng requested a review from Rapptz February 9, 2025 04:38
@Gooraeng
Copy link
Contributor Author

Gooraeng commented Feb 9, 2025

I ran black --line-length 125 --skip-string-normalization discord/webhook/async_.py, but I still have same problem. Should I close and reopen pr again?

@Rapptz
Copy link
Owner

Rapptz commented Feb 9, 2025

We use an older version of black, the 22.6 version so try using that instead.

@Gooraeng
Copy link
Contributor Author

Gooraeng commented Feb 9, 2025

Thanks. It's ready for being merged.

@Rapptz Rapptz merged commit 76eb126 into Rapptz:master Feb 9, 2025
8 checks passed
@Gooraeng Gooraeng deleted the add-a-property branch February 9, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants