Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _fallback attr not being set on replace for Parameter #10077

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix _fallback attr not being set on replace for Parameter #10077

merged 2 commits into from
Jan 16, 2025

Conversation

AbstractUmbra
Copy link
Contributor

@AbstractUmbra AbstractUmbra commented Jan 15, 2025 •
edited
Loading

Fixes #10076

Summary

This changes the .replace() method of Parameter to include the _fallback attr which is set on discord.pys built-in uses of Parameter like Author.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@AbstractUmbra
Fix _fallback attr not being set on replace
d7a8522 
Fixes `_fallback` is not copied by `Parameter.replace` Rapptz#10076
@AbstractUmbra
black
4d5b097
@Rapptz Rapptz merged commit d956058 into Rapptz:master Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_fallback is not copied by Parameter.replace
2 participants
@AbstractUmbra @Rapptz