feat: useFocus 구현 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBSPS
approved these changes
Nov 21, 2024
src/useFocus/useFocus.ts
Outdated
Comment on lines
5
to
6
| threshold?: number, | ||
| rootMargin?: string, |
There was a problem hiding this comment.
threshold = 0.1과 같이 한다면 기본값임을 명확히 알 수 있고 밑에서는 조건이 빠져 읽기 쉬울 것 같아요
There was a problem hiding this comment.
감사합니다
2027151 에서 반영완료했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-11-21.11.34.28.mov
useFocus
DOM Element가 화면에 노출되었을때, callback으로 전달된 함수를 실행합니다.
함수인자
onFocusCallback: 요소가 focus되었을때, 수행할 함수입니다.threshold: 요소가 화면에 보일때의 기준을 결정합니다. 1이면 전체요소가 모두 화면에 들어왔을때 입니다.rootMargin: 화면의 너비, 높이를 조정할 수 있습니다. "top right bottom left" 형태로 기재하며 반드시 단위를 명시해야합니다.반환값
ref: focus될 DOM요소에 할당해줄 ref 객체입니다.관련 이슈
#27