Add CODEOWNERS file #1768
Open
Add CODEOWNERS file #1768
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
requested review from
raghavendra-talur,
rakeshgm,
ShyamsundarR,
BenamarMk and
ELENAGER
nirs
commented
Jan 26, 2025
|
the change looks good, i have given my approval anyway. |
rakeshgm
approved these changes
Jan 27, 2025
ELENAGER
approved these changes
Jan 27, 2025
ELENAGER
reviewed
Jan 28, 2025
nirs
commented
Jan 28, 2025
nirs
commented
Jan 28, 2025
nirs
commented
Jan 28, 2025
nirs
force-pushed
the
codeowners
branch
2 times, most recently
from
8a54047 to
161fe6c
Compare
nirs
commented
Jan 29, 2025
The CODEOWNERS[1] file define individuals or teams that are responsible for code in a repository. People with write permissions for the repository can create or edit the CODEOWNERS file and be listed as code owners. People with admin or owner permissions can require that pull requests have to be approved by code owners before they can be merged. How this change the development flow? - When a pull request is created, owners of file touched by the pull request are added automatically as reviewers. This improves the experience for new contributors. - Using branch protection we can require that at least one of the owners will approve the pull request before it can be merged. - New contributors can learn who owns the code that want to change. [1] https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners Fixes: RamenDR#1766 Signed-off-by: Nir Soffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CODEOWNERS[1] file define individuals or teams that are responsible for code in a repository.
People with write permissions for the repository can create or edit the CODEOWNERS file and be listed as code owners. People with admin or owner permissions can require that pull requests have to be approved by code owners before they can be merged.
How this change the development flow?
When a pull request is created, owners of file touched by the pull request are added automatically as reviewers. This improves the experience for new contributors.
Using branch protection we can require that at least one of the owners will approve the pull request before it can be merged.
New contributors can learn who owns the code that want to change.
Issues:
[1] https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Fixes: #1766