-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to link: unresolved externals from 'pathcch.h' (Windows) #42
Comments
This is likely a bug on our end; thanks for the report! OpenXR 1.0.11 added a use of |
Would you mind testing #43? |
Thanks for the quick reply! |
Just checked some older versions and |
I'm also running into this issue. |
Thanks for the report. The call was added in OpenXR 1.0.11, so older versions of openxrs, which use older versions of the OpenXR loader, should work fine; I recommend rolling back to those until I have time to dig into this further, which should be within the week, unless someone else is able to investigate and make a PR. |
Got some time to test this on my windows box and, oddly, master works just fine for me:
What version of MSVC are you using? |
Hmm that's interesting... |
Had an inverted condition in the first draft of the fix; should work fine now. Published openxr-sys 0.8.4 with the fix. |
I'm running into issues with building with openxr itself. It appears that the symbol for |
The build script used the `cfg!` macro to check the target os, but the "target" in a build script is actually the host. Use the `CARGO_CFG_TARGET_OS` environment variable instead. Issue Ralith#42 [has been worked around](KhronosGroup/OpenXR-SDK-Source#198), and then [fixed upstream](KhronosGroup/OpenXR-SDK-Source#239), so the additional flag on windows is no longer necessary. Linking the filesystem library is also done correctly upstream now: https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/main/src/cmake/StdFilesystemFlags.cmake
The build script used the `cfg!` macro to check the target os, but the "target" in a build script is actually the host. Use the `CARGO_CFG_TARGET_OS` environment variable instead. Issue Ralith#42 [has been worked around](KhronosGroup/OpenXR-SDK-Source#198), and then [fixed upstream](KhronosGroup/OpenXR-SDK-Source#239), so the additional flag on windows is no longer necessary. Linking the filesystem library is also done correctly upstream now: https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/main/src/cmake/StdFilesystemFlags.cmake
The build script used the `cfg!` macro to check the target os, but the "target" in a build script is actually the host. Use the `CARGO_CFG_TARGET_OS` environment variable instead. Issue #42 [has been worked around](KhronosGroup/OpenXR-SDK-Source#198), and then [fixed upstream](KhronosGroup/OpenXR-SDK-Source#239), so the additional flag on windows is no longer necessary. Linking the filesystem library is also done correctly upstream now: https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/main/src/cmake/StdFilesystemFlags.cmake
Tried to build the example and another project but always get this error.
pathcch.h
is part of the win32 library but I should have all the necessary build tools for c++ installed (at least I think so the SDL crate works fine for example)This is the error:
Is there something I am missing?
The text was updated successfully, but these errors were encountered: