Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personalization of causation/correlation/type streams for browser #626

Closed
swistak35 opened this issue Jun 25, 2019 · 4 comments
Closed

Personalization of causation/correlation/type streams for browser #626

swistak35 opened this issue Jun 25, 2019 · 4 comments
Labels

Comments

@swistak35
Copy link
Contributor

Currently, displaying links (at browser) to correlation / causation / type streams work with assumption that our LinkBy* handlers are used with default prefix ($by_correlation_, $by_causation_, $by_type_) and with default metadata field (correlation_id, causation_id, event type).

There are two parts of this task:

  • ability to customize stream names in browser configuration ($by_correlation_, $by_causation_, $by_type_ mentioned above)
  • ability to customize the metadata fields used for that streams (correlation_id, causation_id)

IMO the first task is more important than the second.

@mostlyobvious
Copy link
Member

Is this still an issue?

@grncdr
Copy link

grncdr commented Dec 23, 2020

The behavior mentioned above is still the case, and still confusing.

If you don't set up the LinkBy handlers as described in https://railseventstore.org/docs/v1/correlation_causation/#building-streams-based-on-correlation-id-and-causation-id those elements are still shown in the browser, but link to empty streams.

What I don't understand: why doesn't the ShowEvent view just show links to all streams that contain the event? That would be much more useful to me.

@mostlyobvious mostlyobvious self-assigned this Jan 4, 2021
@mostlyobvious
Copy link
Member

What I don't understand: why doesn't the ShowEvent view just show links to all streams that contain the event? That would be much more useful to me.

Good question! There's already an API for that — streams_of(event_id). I have to remind myself if there were any performance implications.

mostlyobvious added a commit that referenced this issue Sep 21, 2022
This leads to some duplication with how type/correlation/causation
streams are currently displayed. I'll deal with them next.

#626 (comment)
@mostlyobvious
Copy link
Member

What I don't understand: why doesn't the ShowEvent view just show links to all streams that contain the event? That would be much more useful to me.

Scheduled for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants