V0.4

[Raffaello]

• add test for all write methods that should output the same result
• add test for all writeXY methods that should output the same result

[codecov]

Codecov Report

Merging #158 into master will decrease coverage by 2.27%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   90.90%   88.63%   -2.28%     
==========================================
  Files           5        5              
  Lines         374      387      +13     
==========================================
+ Hits          340      343       +3     
- Misses         34       44      +10     

Impacted Files	Coverage Δ
sdl2-vga-terminal/src/VgaTerminal.cpp	90.78% <0.00%> (-3.15%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81e84f...71399ec. Read the comment docs.

[todo]

major version refactor to a struct

instead of having first and second have a struct with x, y.

---

sdl2-vga-terminal/sdl2-vga-terminal/src/VgaTerminal.hpp

Lines 36 to 41 in a182537

	// TODO major version refactor to a struct
	// BODY instead of having first and second
	// BODY have a struct with x, y.
	typedef std::pair<uint8_t, uint8_t> position_t;
	enum class CURSOR_MODE : uint8_t {

---

This comment was generated by todo based on a TODO comment in a182537 in #158. cc @Raffaello.

[todo]

this could be an "utility method" itself

consider to create in VgaTerminal class an operator/method to implement the same functionality here. Probably, not just the same if want to keep the fine element level checks like below.

---

sdl2-vga-terminal/sdl2-vga-terminal/test/VgaTerminalTest.cpp

Lines 11 to 16 in 71399ec

	// TODO this could be an "utility method" itself
	// BODY consider to create in VgaTerminal class
	// BODY an operator/method to implement the same functionality here.
	// BODY Probably, not just the same if want to keep the fine element level checks like below.
	void cmpViewportCheck(const SDL_Rect& vp, const SDL_Rect& exp)
	{

---

This comment was generated by todo based on a TODO comment in 71399ec in #158. cc @Raffaello.

[todo]

this could be an "utility method" itself

consider to create in VgaTerminal class an operator/method to implement the same functionality here. Probably, not just the same if want to keep the fine element level checks like below.

---

sdl2-vga-terminal/sdl2-vga-terminal/test/VgaTerminalTest.cpp

Lines 23 to 28 in 71399ec

	// TODO this could be an "utility method" itself
	// BODY consider to create in VgaTerminal class
	// BODY an operator/method to implement the same functionality here.
	// BODY Probably, not just the same if want to keep the fine element level checks like below.
	void cmpTerminalChar(const VgaTerminal::terminalChar_t& tc1, const VgaTerminal::terminalChar_t& tc2)
	{

---

This comment was generated by todo based on a TODO comment in 71399ec in #158. cc @Raffaello.

[Raffaello]

Here is an overview of what got changed by this pull request:

Clones removed
==============
+ sdl2-vga-terminal/test/VgaTerminalTest.cpp  -2
         

See the complete overview on Codacy

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

0.0% Coverage
0.0% Duplication

The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here