Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codecov] add config file. Fixes #147 #148

Merged
merged 2 commits into from
May 22, 2020
Merged

[codecov] add config file. Fixes #147 #148

merged 2 commits into from
May 22, 2020

Conversation

Raffaello
Copy link
Owner

No description provided.

@Raffaello Raffaello added bug Something isn't working configuration cmake or project related code, configuaration labels May 22, 2020
@Raffaello Raffaello added this to the Better CI milestone May 22, 2020
@Raffaello Raffaello self-assigned this May 22, 2020
@Raffaello Raffaello linked an issue May 22, 2020 that may be closed by this pull request
[codecov] not updating code coverage report #147
Closed
@codecov
Copy link

codecov bot commented May 22, 2020 •
edited
Loading

Codecov Report

Merging #148 into master will increase coverage by 6.08%.
The diff coverage is 82.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   84.69%   90.78%   +6.08%     
==========================================
  Files           2        4       +2     
  Lines         294      358      +64     
==========================================
+ Hits          249      325      +76     
+ Misses         45       33      -12
Impacted Files Coverage Δ
sdl2-vga-terminal/src/exceptions/exceptions.hpp 25.00% <25.00%> (ø)
sdl2-vga-terminal/src/Window.cpp 77.77% <78.04%> (+14.14%) ⬆️
sdl2-vga-terminal/src/VgaTerminal.cpp 93.92% <86.30%> (+5.52%) ⬆️
sdl2-vga-terminal/src/tui/utils.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777012d...c6e81ec. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Raffaello
Copy link
Owner Author

i don't get the failure in codecov/patch task.... 🔢

@Raffaello Raffaello merged commit 2ead297 into master May 22, 2020
@Raffaello Raffaello deleted the codecov branch May 22, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Raffaello Raffaello

Labels
bug Something isn't working configuration cmake or project related code, configuaration
Projects
None yet
Milestone
Better CI
Development

Successfully merging this pull request may close these issues.

[codecov] not updating code coverage report
1 participant
@Raffaello