Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamer doesn't allow only {Original Title} #103

Closed
JudsonHat opened this issue Jan 10, 2017 · 15 comments
Closed

renamer doesn't allow only {Original Title} #103

JudsonHat opened this issue Jan 10, 2017 · 15 comments
Labels
Priority: Medium Issue affects Radarr's functionality in a rather serious way. Type: Bug Issue is a bug
Milestone

Comments

@JudsonHat
Copy link

When trying to use the movie renamer, I am unable to only use the option {Original Title} in the "Standard Movie Format" box. I get a message that says that the movie title must be included.
Invalid request Validation failed: -- Must contain movie title

I see this in the log:

System.ArgumentNullException: Value cannot be null.
Parameter name: input
  at System.Text.RegularExpressions.Regex.IsMatch (System.String input) [0x00006] in <5071a6e4a4564e19a2eda0f53e42f9bd>:0 
  at NzbDrone.Core.Organizer.ValidStandardEpisodeFormatValidator.IsValid (FluentValidation.Validators.PropertyValidatorContext context) [0x0000c] in <b24c4248bad1488899026fb89f2f8b59>:0 
  at FluentValidation.Validators.PropertyValidator.Validate (FluentValidation.Validators.PropertyValidatorContext context) [0x00029] in <8626367d22964351ba30df1437b82408>:0 
  at FluentValidation.Internal.PropertyRule.InvokePropertyValidator (FluentValidation.ValidationContext context, FluentValidation.Validators.IPropertyValidator validator, System.String propertyName) [0x00009] in <8626367d22964351ba30df1437b82408>:0 
  at FluentValidation.Internal.PropertyRule+<Validate>d__60.MoveNext () [0x000e6] in <8626367d22964351ba30df1437b82408>:0 
  at System.Linq.Enumerable+<SelectManyIterator>c__Iterator2`2[TSource,TResult].MoveNext () [0x000bc] in <63992662b765477a898ef49cdcc99ee2>:0 
  at System.Collections.Generic.List`1[T]..ctor (System.Collections.Generic.IEnumerable`1[T] collection) [0x0008b] in <8f2c484307284b51944a1a13a14c0266>:0 
  at System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x00011] in <63992662b765477a898ef49cdcc99ee2>:0 
  at FluentValidation.AbstractValidator`1[T].Validate (FluentValidation.ValidationContext`1[T] context) [0x00034] in <8626367d22964351ba30df1437b82408>:0 
  at FluentValidation.AbstractValidator`1[T].Validate (T instance) [0x0001b] in <8626367d22964351ba30df1437b82408>:0 
  at NzbDrone.Api.REST.RestModule`1[TResource].ReadResourceFromRequest (System.Boolean skipValidate) [0x0002a] in <09957bc2d0f343e884cc5afa0b7d5ae7>:0 
  at NzbDrone.Api.REST.RestModule`1[TResource].<set_UpdateResource>b__44_0 (System.Object options) [0x00000] in <09957bc2d0f343e884cc5afa0b7d5ae7>:0 
  at (wrapper dynamic-method) System.Object:CallSite.Target (System.Runtime.CompilerServices.Closure,System.Runtime.CompilerServices.CallSite,System.Func`2<object, object>,object)
  at Nancy.Routing.Route+<>c__DisplayClass4.<Wrap>b__3 (System.Object parameters, System.Threading.CancellationToken context) [0x00049] in <63c44d6f8d7e4f339a987bf9eb94d931>:0 
@JudsonHat
Copy link
Author

Just upgraded to 2.0.45 and the "Value cannot be null" error has stopped. But I am still unable to only use the option {Original Title}.

@galli-leo galli-leo added Type: Bug Issue is a bug Priority: Medium Issue affects Radarr's functionality in a rather serious way. labels Jan 10, 2017
@galli-leo
Copy link
Contributor

Original title is the original file name. If you just want that you can disable renaming.

@galli-leo galli-leo added this to the 0.2 milestone Jan 10, 2017
@JudsonHat
Copy link
Author

I tried that, but sometimes the original file name is obfuscated. I have this as the setting in Sonarr, and it will rename the obfuscated file name to the nzb name. I guess I could set up nzbget do the renaming and just let radarr import it with renaming disabled.

@galli-leo
Copy link
Contributor

Well we should fix that anyways. In the meantime, you can use that.

@ghost ghost self-assigned this Jan 11, 2017
@simonk83
Copy link

I'd like this too if possible, but for the folder ;) In CP I use the option "Original_Folder" to keep the folder name the same as the release. This way I can see the quality and release group should i want to know what version I have down the line (also comes in very handy for re-adding all movies to a new app like Radarr, as the quality is in the folder name). I rename the actual file to something a bit cleaner, but I like to keep the folder name the same as the original if I can.

@ghost
Copy link

ghost commented Jan 13, 2017

Confirming that the tag {Original Title} does indeed not work, preview stays empty in Rename settings.
Also the tag {Release Group} stays empty in the preview.

@JudsonHat
Copy link
Author

So is {Original Title} supposed to be the original file name or the nzb name? In sonarr, I'm pretty sure it uses the nzb name. But I just tested it in radarr, and it seems to be using the original file name. I admit that I might be completely wrong.

@ghost
Copy link

ghost commented Jan 15, 2017

I too was under the impression that it would be nzb/torrent name and not filename? If not perhaps a bug?

@onedr0p
Copy link
Contributor

onedr0p commented Jan 15, 2017

Doesn't filename make more sense? maybe it should be called {Original Filename} to avoid confusion.

@ghost
Copy link

ghost commented Jan 15, 2017

If it would be filename, you can also disable renaming

I want it to rename to the release name, in most cases this is the same as the filename, but BLOW tends to name the file blow-moviename.1080p.mkv which is impossible for subliminal to parse for subtitles searching. The release name however is always like it should Movie.2016.BluRay............

@simonk83
Copy link

simonk83 commented Jan 15, 2017 via email

@galli-leo
Copy link
Contributor

I think it does use the nzbname. At least it should from my experience.

@jsahlen
Copy link

jsahlen commented Feb 27, 2017

It definitely uses the filename (at least with NZBget as the downloader), which isn't great for obfuscated filenames. They get picked up alright, but are stored as the original obfuscated filename. I think nzb name is the way to go.

@Grubs
Copy link

Grubs commented Sep 3, 2017

Any progress with this one? I've just switched to Radarr and noticed it is using the original filename. Would like to be able to use the nzb name so I can easily see which release has been downloaded. As with the comment above , currently it isn't great for obfuscated filenames.

@galli-leo
Copy link
Contributor

It should be using the Nzb name by now (Provided it's adhereing to scene standards)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Medium Issue affects Radarr's functionality in a rather serious way. Type: Bug Issue is a bug
Projects
None yet
Development

No branches or pull requests

6 participants