Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swdev 362774 #116

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Swdev 362774 #116

merged 2 commits into from
Nov 18, 2022

Conversation

solaiys
Copy link
Contributor

@solaiys solaiys commented Nov 3, 2022

Arguments to prerm script is referenced correctly inside the function in the script.
This is a bug fix to #112

solaiys and others added 2 commits October 19, 2022 08:13
Arguments to prerm script is referenced correctly inside the
function in the script.

Signed-off-by: Saravanan Solaiyappan <[email protected]>
Updated with comments.
Copy link
Collaborator

@lawruble13 lawruble13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures appear to be unrelated. I'll be investigating those, but this looks good.

@nunnikri
Copy link
Contributor

The change is approved by release management to 5.4RC3.

@nunnikri nunnikri merged commit 88fd446 into ROCm:release/rocm-rel-5.4 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants