-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made TBB optional for hipstdpar tests #507
Made TBB optional for hipstdpar tests #507
Conversation
I'm encountering build errors when making the hipstdpar tests in Ubuntu (haven't tried other OSes but I assume they will be the same) when doing: CXX=hipcc cmake -DBUILD_HIPSTDPAR_TEST=ON -DGPU_TARGETS=gfx942 ..
and so on. Even though we did not specify -DBUILD_HIPSTDPAR_TEST_WITH_TBB=ON, it looks like the hipstdpar tests still use TBB. Indeed, if manually add -ltbb to the build command, it builds properly. According to https://stackoverflow.com/questions/67854770/i-do-not-use-tbb-but-i-get-linker-errors-related-to-tbb, it seems like when building with clang, it requires libtbb... |
It seems to be a weird dependency, because it seems to be only needed to add the flag when TBB is installed. I tested it on the |
Build failures are due to compiler bugs which will be resolved in upcoming newer builds. Otherwise, it looks good to me. |
d5c9a92
into
ROCm:release-staging/rocm-rel-6.4
* Enable HIP language (#493) If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX. Co-authored-by: Lauren Wrubleski <[email protected]> * Made TBB optional for hipstdpar tests (#507) * added TBB in dependencies cmake * updated changelog * removed duplicate dependencies declaration in test cmake * Create optional flag to run tests hipstdpar with TBB * Add TBB optional flag to CHANGELOG * Add rocprim location to hipstdpar * Add default and test for DONWLOAD_ROCRAND * Build with TBB when available or when FLAG is set --------- Co-authored-by: NguyenNhuDi <[email protected]> * Separate CMake BUILD_TEST and BUILD_HIPSTDPAR_TEST options (#508) * Separate CMake BUILD_TEST and BUILD_HIPSTDPAR_TEST options Previously, enabling BUILD_TEST would also enable hipstdpar tests if we detected that a c++17-capable compiler was present. However, this caused build issues on systems with a c++17 compiler but an outdated version of libstdc++ that didn't support c++17 (RHEL 8.x). Currently, we require a minimum cmake version of 3.10.2. There's no real robust way of detecting the libstdc++ version that will work that far back. To workaround this problem for now, this change splits the BUILD_TEST and BUILD_HIPSTDPAR_TEST cmake options so that they are independent. This means that in order to enable hipstdpar tests, the user must explicitly enable the BUILD_HIPSTDPAR_TEST option. Update the readme to reflect this. * Update README.md Co-authored-by: Leo Paoletti <[email protected]> --------- Co-authored-by: Di Nguyen <[email protected]> Co-authored-by: Leo Paoletti <[email protected]> * Updated known issue for inclusive_scan_by_key compiler bug (#513) * updated the known issue * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * moved known issue to 6.4 section * updated to include that the issue has been fixed --------- Co-authored-by: spolifroni-amd <[email protected]> * Extend fallback coverage for copy_if (#512) We recently added a "fallback" implementation for thrust::copy_if that is invoked when copying a custom type that's too large to fit in shared memory. This change extends the fallback slightly so that it can be used with an overload of copy_if that accepts a stencil buffer (to copy by key). It also adds a unit test to cover this case. It also fixes a small bug in the fallback implementation that could cause the scan accumulator type to overflow when the results are compacted. --------- Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Nick Breed <[email protected]> Co-authored-by: NguyenNhuDi <[email protected]> Co-authored-by: Di Nguyen <[email protected]> Co-authored-by: Leo Paoletti <[email protected]> Co-authored-by: spolifroni-amd <[email protected]>
Hipstdpar should work with and without TBB, so made a flag that as a default is
OFF
to make use or not of TBB.Also set the rocprim path to hipstdpar and created a default value for another unrelated flag.
I have also added the commits from this #506 (comment) MR.