Add changelog entry about hipGraph support #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
and removed request for
a team
stanleytsang-amd
requested changes
May 31, 2024
There was a problem hiding this comment.
I think we should made a page in the documentation on this. It'll be too easy for this information to get buried in the changelog after a few releases.
If the list isn't too large we could also list which functions do work with hipGraphs in that documentation page.
|
Thanks Stanley, that makes a lot of sense. I'm just sorting out a few issues with the documentation build and then I'll add this in. |
Currently, we don't support calling rocThrust API function from within hipGraphs. Add a note to the changelog, and a page to the documentation to indicate this.
|
I've added a documentation page on hipGraphs. You can view the formatted version in the readthedocs build for this PR here: https://advanced-micro-devices-demo--412.com.readthedocs.build/projects/rocThrust/en/412/ |
stanleytsang-amd
approved these changes
Jun 18, 2024
randyh62
added a commit
that referenced
this pull request
Jul 4, 2024
* Bump jinja2 from 3.1.3 to 3.1.4 in /docs/sphinx (#406) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update replace.h (#413) correct CopyAssignable link error * Update Read the Docs configuration to use Python 3.10 and latest rocm-docs-core (#419) * Add documentation for HIP backend policies (par, par_nosync) (#421) The HIP backend defines two policies (hip_rocprim::par, hip_rocprim::par_nosync) that may be of interest to users who want more control over the way their algorithms are executing. The par_nosync policy is currently documented in the thrust changelog, but is not part of the rocThrust documentation. This change adds a description of par and par_nosync to the documentation, along with a code example. * Bump urllib3 from 2.2.1 to 2.2.2 in /docs/sphinx (#423) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add changelog entry and documentation regarding hipGraph support (#412) Currently, we don't support calling rocThrust API function from within hipGraphs. Add a note to the changelog, and a page to the documentation to indicate this. * Bump rocm-docs-core from 1.4.0 to 1.4.1 in /docs/sphinx (#425) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Wu <[email protected]> Co-authored-by: Wayne Franz <[email protected]>
samjwu
added a commit
that referenced
this pull request
Jul 4, 2024
* Bump jinja2 from 3.1.3 to 3.1.4 in /docs/sphinx (#406) Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update replace.h (#413) correct CopyAssignable link error * Update Read the Docs configuration to use Python 3.10 and latest rocm-docs-core (#419) * Add documentation for HIP backend policies (par, par_nosync) (#421) The HIP backend defines two policies (hip_rocprim::par, hip_rocprim::par_nosync) that may be of interest to users who want more control over the way their algorithms are executing. The par_nosync policy is currently documented in the thrust changelog, but is not part of the rocThrust documentation. This change adds a description of par and par_nosync to the documentation, along with a code example. * Bump urllib3 from 2.2.1 to 2.2.2 in /docs/sphinx (#423) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add changelog entry and documentation regarding hipGraph support (#412) Currently, we don't support calling rocThrust API function from within hipGraphs. Add a note to the changelog, and a page to the documentation to indicate this. * Bump rocm-docs-core from 1.4.0 to 1.4.1 in /docs/sphinx (#425) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Wu <[email protected]> Co-authored-by: Wayne Franz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't support calling rocThrust API function from within hipGraphs.
Add a note to the changelog to indicate this.