Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azurelinux os name for gfortran dependency (#891) #423

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

ntrost57
Copy link
Contributor

No description provided.

@ntrost57 ntrost57 requested review from a team, YvanMokwinski and jsandham as code owners November 12, 2024 07:13
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the placement of this issue within the changelog

CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ Documentation for rocSPARSE is available at

* Add `rocsparse_create_extract_descr`, `rocsparse_destroy_extract_descr`, `rocsparse_extract_buffer_size`, `rocsparse_extract_nnz`, and `rocsparse_extract` APIs to allow extraction of the upper or lower part of sparse CSR or CSC matrices.
* Support for the gfx1151, gfx1200, and gfx1201 architectures.
* Added `azurelinux` OS name for correcting gfortran dependency
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into the Resolved issues section if it's correcting something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I cannot answer that. I thought supporting azurelinux was new. But I can move it over, if required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If support for Azure Linux is new, then it can stay where it is, even if a correction is required somewhere else. Thanks for the clarification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll double check whether this is something new or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going with Fixed `azurelinux` OS name for gfortran dependency

Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Co-authored-by: Jeffrey Novotny <[email protected]>
@vamovsik vamovsik merged commit ed5da19 into ROCm:release/rocm-rel-6.3 Nov 18, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants