Updates and test coverage for hipGraph support in rocRAND (#439) <cherry-picked from develop> #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows device-side generators to be used inside of hipGraphs. More specifically, you can wrap calls to rocrand_generate_* inside of a hipGraph. There are a few things to be aware of: - Generator creation (rocrand_create_generator), initialization (rocrand_initialize_generator), and destruction (rocrand_destroy_generator) must still happen outside the hipGraph. - After the generator is created, you may call API functions to set its seed, offset, and order. - After the generator is initialized (but before stream capture or manual graph creation begins), use rocrand_set_stream to set the stream the generator will use within the graph. - A generator's seed, offset, and stream may not be changed from within the hipGraph. Attempting to do so may result in unpredicable behaviour. - API calls for the poisson distribution (eg. rocrand_generate_poisson) are not yet supported inside of hipGraphs. I've added a note to the changelog that mentions these details. In addition to the changes necessary to support the behaviour described above, this change also: - updates the changelog to alert the user to the restrictions mentioned above - adds new unit test coverage to exercises generators and distributions within hipGraphs.
umfranzw
requested review from
a team,
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
stanleytsang-amd
approved these changes
May 1, 2024
|
@randyh62 Could you review this please? Need an approval from docs team. |
stanleytsang-amd
merged commit d8d8ec9
into
ROCm:release-staging/rocm-rel-6.2
20 of 23 checks passed
stanleytsang-amd
added a commit
that referenced
this pull request
Jul 16, 2024
* Update device-specific config headers with benchmark tuning results (#483) I ran the benchmark tuning code and scripts on the remaining architectures in our GPU support matrix. This change updates the config headers with the results. * Updates and test coverage for hipGraph support in rocRAND (#439) (#482) This change allows device-side generators to be used inside of hipGraphs. More specifically, you can wrap calls to rocrand_generate_* inside of a hipGraph. There are a few things to be aware of: - Generator creation (rocrand_create_generator), initialization (rocrand_initialize_generator), and destruction (rocrand_destroy_generator) must still happen outside the hipGraph. - After the generator is created, you may call API functions to set its seed, offset, and order. - After the generator is initialized (but before stream capture or manual graph creation begins), use rocrand_set_stream to set the stream the generator will use within the graph. - A generator's seed, offset, and stream may not be changed from within the hipGraph. Attempting to do so may result in unpredicable behaviour. - API calls for the poisson distribution (eg. rocrand_generate_poisson) are not yet supported inside of hipGraphs. I've added a note to the changelog that mentions these details. In addition to the changes necessary to support the behaviour described above, this change also: - updates the changelog to alert the user to the restrictions mentioned above - adds new unit test coverage to exercises generators and distributions within hipGraphs. * workaround for regression in sobol kernel (#485) (#487) introduced by generic codepath for host and device generator Co-authored-by: Nol Moonen <[email protected]> * Rename test_config_dispatch.cpp to test_rocrand_config_dispatch.cpp (#496) * fix(lfsr113,mgr,,mtgp32,philox4x32,threefry,xorwow): force inline generate function (#495) (#497) A compiler change caused the generate function to no longer be inlined which caused a performance regression. Force inlining resolves this. Co-authored-by: Nara <[email protected]> * cmake: don't set CMAKE_C_COMPILER, as rocRAND is a CXX project (#502) * cherry picking documentation from develop into 6.2 (#507) * organizing docs into subfolders * update license and index * Update LICENSE.txt Co-authored-by: Nara <[email protected]> * removing what-is-rocRAND * Update Read the Docs configuration to use Python 3.10 and latest rocm-docs-core (#503) * Bump urllib3 from 2.2.1 to 2.2.2 in /docs/sphinx (#505) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Nara <[email protected]> Co-authored-by: Sam Wu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add an option for using TBB for host-side generators * Add package dependencies on TBB if used * Correct dependencies for RHEL / SLES --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Wayne Franz <[email protected]> Co-authored-by: Nol Moonen <[email protected]> Co-authored-by: Nara <[email protected]> Co-authored-by: Steve Leung <[email protected]> Co-authored-by: srawat <[email protected]> Co-authored-by: Nara <[email protected]> Co-authored-by: Sam Wu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lauren Wrubleski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows device-side generators to be used inside of hipGraphs. More specifically, you can wrap calls to rocrand_generate_* inside of a hipGraph. There are a few things to be aware of:
I've added a note to the changelog that mentions these details. In addition to the changes necessary to support the behaviour described above, this change also: