Remove deprecated references to amdgpu-target #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobsonRLemos
approved these changes
Oct 5, 2023
stanleytsang-amd
added a commit
that referenced
this pull request
Nov 8, 2023
* Add const to benchmark rocrand_device_api functions * Add static to benchmark_rocrand_device_api function * Address cppcheck warnings to benchmark_rocrand_generate * Address cppcheck warnings to benchmark_rocrand_kernel * Address cppcheck warnings to cmdparser * Address cppcheck warnings to rocrand.hpp * Address cppcheck warnings to rocrand_mrg31k3p * Address cppcheck warnings to rocrand_mrg32k3a * Address cppcheck warnings to rocrand_mtgp32 * Address cppcheck warnings to rocrand_philox4x32_10 * Address cppcheck warnings to rocrand_sobol32 * Address cppcheck warnings to rocrand_sobol64 * Address cppcheck warnings to rocrand_threefry2_impl * Address cppcheck warnings to rocrand_threefry4_impl * Address cppcheck warnings to rocrand_xorwow * Address cppcheck warnings to discrete * Address cppcheck warnings to poisson * Fix cpp-check warnings * Merge back hotfixes from 5.7 (#385) (#391) * Enable gfx94x build targets (#353) --------- * 5.7 cherry pick - Benchmark perf. improvements for discrete distributions (#379) * Remove workaround with hipGridDim_x * hipBlockDim_x It makes no difference anymore on ROCm >= 5.5, probably after switching to code object v5. * Use restrict with tables of discrete distributions This change improves performance in device API benchamrks for most engines. --------- --------- Co-authored-by: Stanley Tsang <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]> * Updating changelog with correct categorizations (#393) * Remove deprecated references to amdgpu-target (#397) --------- Co-authored-by: RobsonRLemos <[email protected]> Co-authored-by: Robson Lemos <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]>
stanleytsang-amd
added a commit
that referenced
this pull request
Jan 17, 2024
* Add const to benchmark rocrand_device_api functions * Add static to benchmark_rocrand_device_api function * Address cppcheck warnings to benchmark_rocrand_generate * Address cppcheck warnings to benchmark_rocrand_kernel * Address cppcheck warnings to cmdparser * Address cppcheck warnings to rocrand.hpp * Address cppcheck warnings to rocrand_mrg31k3p * Address cppcheck warnings to rocrand_mrg32k3a * Address cppcheck warnings to rocrand_mtgp32 * Address cppcheck warnings to rocrand_philox4x32_10 * Address cppcheck warnings to rocrand_sobol32 * Address cppcheck warnings to rocrand_sobol64 * Address cppcheck warnings to rocrand_threefry2_impl * Address cppcheck warnings to rocrand_threefry4_impl * Address cppcheck warnings to rocrand_xorwow * Address cppcheck warnings to discrete * Address cppcheck warnings to poisson * Fix cpp-check warnings * Merge back hotfixes from 5.7 (#385) (#391) * Enable gfx94x build targets (#353) --------- * 5.7 cherry pick - Benchmark perf. improvements for discrete distributions (#379) * Remove workaround with hipGridDim_x * hipBlockDim_x It makes no difference anymore on ROCm >= 5.5, probably after switching to code object v5. * Use restrict with tables of discrete distributions This change improves performance in device API benchamrks for most engines. --------- --------- Co-authored-by: Stanley Tsang <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]> * Updating changelog with correct categorizations (#393) * Remove deprecated references to amdgpu-target (#397) * Update version for ROCm 6.0 (#425) --------- Co-authored-by: RobsonRLemos <[email protected]> Co-authored-by: Robson Lemos <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]>
parbenc
pushed a commit
to StreamHPC/rocRAND
that referenced
this pull request
Mar 22, 2024
* Add const to benchmark rocrand_device_api functions * Add static to benchmark_rocrand_device_api function * Address cppcheck warnings to benchmark_rocrand_generate * Address cppcheck warnings to benchmark_rocrand_kernel * Address cppcheck warnings to cmdparser * Address cppcheck warnings to rocrand.hpp * Address cppcheck warnings to rocrand_mrg31k3p * Address cppcheck warnings to rocrand_mrg32k3a * Address cppcheck warnings to rocrand_mtgp32 * Address cppcheck warnings to rocrand_philox4x32_10 * Address cppcheck warnings to rocrand_sobol32 * Address cppcheck warnings to rocrand_sobol64 * Address cppcheck warnings to rocrand_threefry2_impl * Address cppcheck warnings to rocrand_threefry4_impl * Address cppcheck warnings to rocrand_xorwow * Address cppcheck warnings to discrete * Address cppcheck warnings to poisson * Fix cpp-check warnings * Merge back hotfixes from 5.7 (ROCm#385) (ROCm#391) * Enable gfx94x build targets (ROCm#353) --------- * 5.7 cherry pick - Benchmark perf. improvements for discrete distributions (ROCm#379) * Remove workaround with hipGridDim_x * hipBlockDim_x It makes no difference anymore on ROCm >= 5.5, probably after switching to code object v5. * Use restrict with tables of discrete distributions This change improves performance in device API benchamrks for most engines. --------- --------- Co-authored-by: Stanley Tsang <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]> * Updating changelog with correct categorizations (ROCm#393) * Remove deprecated references to amdgpu-target (ROCm#397) --------- Co-authored-by: RobsonRLemos <[email protected]> Co-authored-by: Robson Lemos <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]>
parbenc
pushed a commit
to StreamHPC/rocRAND
that referenced
this pull request
Mar 22, 2024
* Add const to benchmark rocrand_device_api functions * Add static to benchmark_rocrand_device_api function * Address cppcheck warnings to benchmark_rocrand_generate * Address cppcheck warnings to benchmark_rocrand_kernel * Address cppcheck warnings to cmdparser * Address cppcheck warnings to rocrand.hpp * Address cppcheck warnings to rocrand_mrg31k3p * Address cppcheck warnings to rocrand_mrg32k3a * Address cppcheck warnings to rocrand_mtgp32 * Address cppcheck warnings to rocrand_philox4x32_10 * Address cppcheck warnings to rocrand_sobol32 * Address cppcheck warnings to rocrand_sobol64 * Address cppcheck warnings to rocrand_threefry2_impl * Address cppcheck warnings to rocrand_threefry4_impl * Address cppcheck warnings to rocrand_xorwow * Address cppcheck warnings to discrete * Address cppcheck warnings to poisson * Fix cpp-check warnings * Merge back hotfixes from 5.7 (ROCm#385) (ROCm#391) * Enable gfx94x build targets (ROCm#353) --------- * 5.7 cherry pick - Benchmark perf. improvements for discrete distributions (ROCm#379) * Remove workaround with hipGridDim_x * hipBlockDim_x It makes no difference anymore on ROCm >= 5.5, probably after switching to code object v5. * Use restrict with tables of discrete distributions This change improves performance in device API benchamrks for most engines. --------- --------- Co-authored-by: Stanley Tsang <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]> * Updating changelog with correct categorizations (ROCm#393) * Remove deprecated references to amdgpu-target (ROCm#397) * Update version for ROCm 6.0 (ROCm#425) --------- Co-authored-by: RobsonRLemos <[email protected]> Co-authored-by: Robson Lemos <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Eiden Yoshida <[email protected]> Co-authored-by: Anton Gorenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ROCm/hipRAND#84