Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary operator #338

Merged
merged 33 commits into from
Mar 20, 2025
Merged

Binary operator #338

merged 33 commits into from
Mar 20, 2025

Conversation

CongMa13
Copy link
Collaborator

No description provided.

@CongMa13
add hiptensor_elementwise_binary.cpp and refactor instance_params.*
5691442
@CongMa13
refactor hash key
7a7ec20
@CongMa13
change solutions.
2f32d3b
@CongMa13
update permutation_solution_registry::query
66a5831
@CongMa13
add elementwise_binary_solution_rank3_float_noop_instances.cpp
762e56f
@CongMa13
add binary op cpu_reference_rank4
2ec7bf6
@CongMa13
Add HiptensorBinaryOp
9156348
@CongMa13
add elementwise_binary_solution_rank*_float_noop_instances.cpp
5f20429
@CongMa13
format
f478ff5
@CongMa13
add elementwise binary half instances
5f6e138
@CongMa13
rename permutation_resource.* to elementwise_resource.*
59ef1f6
@CongMa13
change permutation_resource.* to elementwise_resource.*
3a5eb8e
@CongMa13
add unit test rank2_binary_op_test_params.yaml
d582e30
@CongMa13
fix bug in yaml_parser_config.cpp
34bc153
@CongMa13
add rank3-6 elementwise_binary_op_test
229d5fa
@CongMa13
rename PermutationInstanceType_t to ElementwiseExecutionSpaceType_t
9bd93a5
@CongMa13
rename InstanceType_t to ElementwiseInstanceType_t
58a3372
@CongMa13
disable rank3-6 to speed up the compilation
b1ccf21
@CongMa13
change DeviceElementwiseParams to accept InScalarPerVectorSeq of vary…
944e163 
…ing length
@CongMa13
move permutation unit test yaml files
8676818
@CongMa13
add support to f64
73f2ce0
@CongMa13
Changed the combined operator in permutation
fb498ac 
From UnaryCombinedOp<HiptensorUnaryOp, Scale, HiptensorUnaryOp> to
UnaryCombinedOp<HiptensorUnaryOp, Scale>
@CongMa13
format code
f309dff
@CongMa13
add elementwise_trinary(test failed)
3db352f
@CongMa13
add trinary ops
7e95138
@CongMa13
format
be0e433
@CongMa13
fix binary op cpu row_major error
b61dcff
@CongMa13
format
dbdfd42
@CongMa13
disable rank2_elementwise_trinary_op_test
7ad17c5
@CongMa13 CongMa13 marked this pull request as ready for review March 17, 2025 19:33
cgmillette
cgmillette reviewed Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just a few style things to address.

@CongMa13 CongMa13 requested a review from Ryker0627 as a code owner March 19, 2025 17:01
cgmillette
cgmillette approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgmillette
Copy link
Collaborator

Make sure to sync with release-staging as well

@CongMa13 CongMa13 merged commit 4b28f6f into ROCm:develop Mar 20, 2025
19 checks passed
CongMa13 added a commit that referenced this pull request Mar 28, 2025
@CongMa13
Binary operator (#338)
88feb9e 
* Added dynamic binary element-wise operator
* Added element-wise binary operation support
* Added element-wise trinary operation support
* Added unit tests of element-wise binary operation support
* Added unit tests of element-wise trinary operation support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgmillette cgmillette cgmillette approved these changes

@Ryker0627 Ryker0627 Ryker0627 approved these changes

@bragadeesh bragadeesh Awaiting requested review from bragadeesh

@dlangbe dlangbe Awaiting requested review from dlangbe dlangbe is a code owner

@afanfa afanfa Awaiting requested review from afanfa afanfa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CongMa13 @cgmillette @Ryker0627