Fix OS detection for CPack dependencies #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYSTEM_OS and SYSTEM_OS_VERSION variables were mixed up when they were renamed in 9137cd5.
tfalders
approved these changes
Jan 3, 2024
jzuniga-amd
approved these changes
Jan 3, 2024
This checks that the package can be installed.
We need to set --allow-unsigned-rpm to install the locally-built RPMs, but we'll just do it as a dry-run so that we don't accidentally install a dependency without a signature check.
There's no particular reason why we couldn't install the package, but this is consistent with the behaviour for SLES.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use of the
SYSTEM_OSandSYSTEM_OS_VERSIONvariables were mixed up when they were renamed fromCLIENTS_OSandCLIENTS_OS_VERSIONin 9137cd5.