Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG to describe ROCm 5.7 contribution #2075

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Conversation

causten
Copy link
Collaborator

@causten causten commented Aug 15, 2023

Changes are based on internal review of all the PRs since 5.6. Should not contain incomplete features, or inter-release fixes.

CHANGELOG.md Outdated
- Enabled hipRTC allowing the ROCm install to not be required in /opt/rocm specifically
- Add support for multi-target execution
- Added Dynamic Batch support with C++/Python APIs
- Enabled native int32 type support
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch it came from #1721. Reading the PR message I think it should be removed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a bug fix. It could say Fix issues with GPU handling of int32 data type.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2075 (087b8fc) into develop (ea32ca7) will decrease coverage by 0.03%.
Report is 1 commits behind head on develop.
The diff coverage is 42.85%.

❗ Current head 087b8fc differs from pull request most recent head 5dc1850. Consider uploading reports for the commit 5dc1850 to get more accurate results

@@             Coverage Diff             @@
##           develop    #2075      +/-   ##
===========================================
- Coverage    91.41%   91.38%   -0.03%     
===========================================
  Files          422      422              
  Lines        15648    15655       +7     
===========================================
+ Hits         14304    14306       +2     
- Misses        1344     1349       +5     
Files Changed Coverage Δ
src/eliminate_contiguous.cpp 92.30% <42.85%> (-7.70%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Aug 15, 2023

Test Batch Rate new
5dc185
Rate old
27edcf
Diff Compare
torchvision-resnet50 64 2,275.55 2,275.98 -0.02%
torchvision-resnet50_fp16 64 5,345.41 5,340.05 0.10%
torchvision-densenet121 32 1,823.49 1,836.33 -0.70%
torchvision-densenet121_fp16 32 3,377.66 3,384.23 -0.19%
torchvision-inceptionv3 32 1,341.52 1,345.83 -0.32%
torchvision-inceptionv3_fp16 32 2,532.55 2,527.29 0.21%
cadene-inceptionv4 16 676.59 680.86 -0.63%
cadene-resnext64x4 16 589.05 589.69 -0.11%
slim-mobilenet 64 7,225.79 7,212.94 0.18%
slim-nasnetalarge 64 236.07 236.41 -0.14%
slim-resnet50v2 64 2,520.26 2,520.75 -0.02%
bert-mrpc-onnx 8 717.58 717.35 0.03%
bert-mrpc-tf 1 363.64 363.33 0.09%
pytorch-examples-wlang-gru 1 314.45 301.46 4.31% 🔆
pytorch-examples-wlang-lstm 1 316.07 307.28 2.86%
torchvision-resnet50_1 1 556.41 553.99 0.44%
torchvision-inceptionv3_1 1 308.05 308.06 -0.00%
cadene-dpn92_1 1 367.25 365.70 0.43%
cadene-resnext101_1 1 219.58 220.14 -0.25%
slim-vgg16_1 1 224.04 223.90 0.07%
slim-mobilenet_1 1 1,543.22 1,538.67 0.30%
slim-inceptionv4_1 1 224.09 218.89 2.38%
onnx-taau-downsample 1 321.96 321.03 0.29%
dlrm-criteoterabyte 1 21.65 21.64 0.01%
dlrm-criteoterabyte_fp16 1 40.56 40.48 0.19%
agentmodel 1 6,045.47 6,047.23 -0.03%
unet_fp16 2 54.97 54.91 0.10%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output


🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten self-assigned this Aug 16, 2023
@causten causten merged commit 3f0f55d into develop Aug 17, 2023
@causten causten deleted the changelog_develop branch August 17, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants