-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG to describe ROCm 5.7 contribution #2075
Conversation
CHANGELOG.md
Outdated
- Enabled hipRTC allowing the ROCm install to not be required in /opt/rocm specifically | ||
- Add support for multi-target execution | ||
- Added Dynamic Batch support with C++/Python APIs | ||
- Enabled native int32 type support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch it came from #1721. Reading the PR message I think it should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a bug fix. It could say Fix issues with GPU handling of int32 data type
.
Codecov Report
@@ Coverage Diff @@
## develop #2075 +/- ##
===========================================
- Coverage 91.41% 91.38% -0.03%
===========================================
Files 422 422
Lines 15648 15655 +7
===========================================
+ Hits 14304 14306 +2
- Misses 1344 1349 +5
|
Check results before merge 🔆 |
🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output |
Changes are based on internal review of all the PRs since 5.6. Should not contain incomplete features, or inter-release fixes.