Build testing and missing pyserial dependency #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for getting this setup. I would also like to setup some GitHub action to run the linters before merging into main is possible. |
|
Sounds great! I'll open up another pull request for a GitHub action using a Docker based build later today. |
|
See #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that ar3_ros packages failed when using
colcon testand that thepyserialdependency was missing for the calibration scripts.For linting c++ code uncrustify and cpplint were active automatically and conflicted themself. With this pull request, for linting c++ code, ament lint and clang format is used. I reformatted the packages code, mostly using automatically, which is supported by clang format. Running
colcon testshould now work without any test failures.