Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11.1-alpha.2 #35

Open
wants to merge 15 commits into
base: v0.11_fixes
Choose a base branch
from
Open

0.11.1-alpha.2 #35

wants to merge 15 commits into from

Conversation

zoedberg
Copy link
Collaborator

@zoedberg zoedberg commented Mar 13, 2025

This PR updates the tests to the v0.11 fixes and improvements epic - part 2 (part 1: #30).

The part 2 of the epic includes the following fixes/changes:

  • update MSRV to 1.80.0 (due to aws-lc-sys)
  • remove duplication of check_chain_net on the AnyResolver
  • lint with Rust 1.85.0
  • fix STL and unit tests that were left out in part 1
  • add a test to show bug when using WitnessOrd::Ignored + fix select valid witness when using WitnessOrd::Ignored (make sure to select mined/mempool TXs first)
  • add unsafe history checks on validation (unsafe means the witness TX might be at risk in case of a reorg, because it doesn't have enough confirmations)
  • add a method to check if allocations of an outpoint may be at risk if spent (particularly important when merging allocations during send, because a merged allocation that becomes invalid invalidates other all the other allocations as well)
  • change some validation warnings to errors + do not throw error during validation if consignment has some warnings
  • remove blank transitions (they were causing an inflation bug and making all other transitions unneeded)
  • drop supplements (feature was incomplete and unused)
  • drop extensions and valencies (no immediate use case was found and the feature was incomplete, will maybe reintroduce them in the future)
  • drop interfaces (simplify schema handling, drop incomplete/unused code and reduce testing surface)
  • drop RgbIsa timechain (was just a placheholder, will be reintroduced if a use case that needs it arises)
  • move indexers from rgb-runtime to rgb-std (so a wallet can avoid depending on rgb-runtime, which depends on bp-wallet, if it only needs to use the resolvers)
  • drop computed state (defined in RCP-240327A) placeholders (it should be possible to do in a non-consesus way)

This is not yet complete, we'll add more commits in the following days and update the description accordingly.

Involved PRs:

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.35%. Comparing base (9616b3a) to head (a1b8e57).

Additional details and impacted files
@@               Coverage Diff               @@
##           v0.11_fixes      #35      +/-   ##
===============================================
+ Coverage        37.10%   38.35%   +1.24%     
===============================================
  Files              276      255      -21     
  Lines            41375    37760    -3615     
===============================================
- Hits             15354    14481     -873     
+ Misses           26021    23279    -2742     
Flag Coverage Δ
rust 38.35% <ø> (+1.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant