Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARQL/Update query-types #17

Closed
indeyets opened this issue Nov 21, 2013 · 3 comments
Closed

SPARQL/Update query-types #17

indeyets opened this issue Nov 21, 2013 · 3 comments
Labels
bug
Milestone
1.6.1

Comments

@indeyets
Copy link
Contributor

Right now, 3 query-types for SPARQL/Update are defined: INSERT, DELETE, MODIFY and query-type is detected via regular expression.

The problem is, that there is no MODIFY keyword in SPARQL/Update grammer as modify query is defined as ( 'WITH' iri )? ( DeleteClause InsertClause? | InsertClause ) UsingClause* 'WHERE' GroupGraphPattern.

On the other hand, there is a bunch of query-types unknown to SPARQLWrapper (LOAD, CLEAR, DROP, etc.)
@wikier
Copy link
Member

wikier commented Jun 15, 2014

The unknown query types have been fixed with pull #29.

I'll take a look how to fix the regex that does the query type detection to support the new modify syntax.

@wikier wikier added this to the 1.6.1 milestone Jun 15, 2014
wikier added a commit that referenced this issue Jul 20, 2014
@wikier
removed non-normative MODIFY keyworkd (issue #17)
f3cb574
wikier added a commit that referenced this issue Jul 20, 2014
@wikier
completelly removed non-normative MODIFY keyworkd (issue #17)
99a2721
wikier added a commit that referenced this issue Jul 20, 2014
@wikier
added tests using the keyword 'WITH' (issue #17)
13ff1e4
@wikier wikier mentioned this issue Jul 20, 2014
Merged
wikier added a commit that referenced this issue Jul 20, 2014
@wikier
removed modify from the module file (issue #17)
d225986
wikier added a commit that referenced this issue Jul 20, 2014
@wikier
cleanup MODIFY traces (issue #17)
727ac35
@wikier
Copy link
Member

wikier commented Jul 21, 2014

@indeyets any test that we could add to warranty this fix?

@indeyets
Copy link
Contributor Author

@wikier can't think of anything which would make sense in terms of current implementation. it's ok to close it.

@wikier wikier added the bug label Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.6.1
Development

No branches or pull requests
2 participants
@indeyets @wikier