Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @base URI to have a trailing hash '#' #407

Merged
merged 5 commits into from
Jul 12, 2014
Merged

Conversation

nicholsn
Copy link
Contributor

This PR is to address #379 and allow the @base directive URI to have a trailing hash '#'.

  • adds a test for both @prefix and @base to allow trailing hash
  • comments out previous check for hash ported over from cwm

@satra
Copy link
Contributor

satra commented Jul 11, 2014

i would maintain py2.6 compatibility if the rest of rdflib is py2.6 compatible. all you need to do is add the check to your test.

like this:
https://github.com/trungdong/prov/blob/master/prov/tests/test_model.py#L23

@gromgull
Copy link
Member

Looks good, thanks!

@nicholsn
Copy link
Contributor Author

sweet, learned something new =)

is there a way to trigger travis w/o another commit? looks like the py2.6 had an error installing coveralls...

error: [Errno 104] Connection reset by peer

@gromgull
Copy link
Member

There is a way to redo builds, but only for admins I'm afraid. I've started it now!

@nicholsn
Copy link
Contributor Author

great, thank you! all passed and looks good to merge.

gromgull added a commit that referenced this pull request Jul 12, 2014
Allow @base URI to have a trailing hash '#'
@gromgull gromgull merged commit 98e905e into RDFLib:master Jul 12, 2014
@gromgull
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parsing Related to a parsing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants