Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importlib-metadata pin a lower bound #214

Closed
wants to merge 1 commit into from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Nov 8, 2023

Thanks for maintaining pySHACL, and congratulations on 0.24.0 🎉 !

This PR makes the new pin on importlib-metadata viable in a wider range of environments: at least in the conda-forge downstream, other packages in the test environment pull in importlib-metadata 6.x, and pass with this patch.

As python 3.7 is also dropped in the conda-forge ecosystem, there may be other new pins that are challenging, but we won't be able to find them.

@bollwyvl bollwyvl marked this pull request as ready for review November 8, 2023 16:19
@ashleysommer
Copy link
Collaborator

Thanks for your change here.
For context, this is why I pinned it to 4.13
image

PySHACL supports Python 3.8-3.11, and Python 3.11 already has a comptible version of importlib.metadata in the std library, so I chose to use importlib_metadata package match that found in v3.11, for python versions earlier than 3.11.

@ashleysommer
Copy link
Collaborator

Note, during this development cycle of PySHACL, before the next release, we are dropping Python 3.7 and adding v3.12 to the support matrix, so I suppose it makes sense to move this importlib_metadata pin to 6.5.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Nov 9, 2023

Hard pins are generally... hard for downstreams. And the importlib family of APIs is... troublesome.

Either way, we went ahead and shipped with this patch, but typically I try to at least make them apparent upstream. Feel free to close if this is not desired.

@ashleysommer
Copy link
Collaborator

Hi @bollwyvl
If its possible, can you please test a conda-forge build using the new drop_37 branch? #216
That should also contain a solution to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants