Add test for --allow-levels #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test demonstrates the current implementation state fails. A follow-on patch will correct the issue. References: * RDFLib#126 * The general style of this test was adapted from `/test/issues/test_96.py`. Signed-off-by: Alex Nelson <[email protected]>
This lets `allow_infos` to influence the `all_warn` variable appropriately. With this patch, the new `test_126.py` now passes. References: * RDFLib#126 Signed-off-by: Alex Nelson <[email protected]>
|
@ashleysommer : This patch series should settle the accidentally unimplemented part of PR 121. It does not handle documentation (README) revisions. I found there were other effects from recent updates, so I'll file a separate PR for that. |
ajnelson-nist
added a commit
to ucoProject/UCO
that referenced
this pull request
Feb 28, 2022
UCO CP-100 is the first proposal to make use of shapes of a severity other than the default `sh:Violation`. This patch allows an affirmative SHACL conformance result with all non-Violation-level validation results. The flag used on `pyshacl` is `--allow-warnings`. At the time of this patch, `--allow-infos` is implemented, but not yet released (see pySHACL PR 127). The tests for semi-open vocabularies are accordingly revised to move the Info-level validation results into the PASS sample file. The Make-managed validation results files are regenerated in this patch. References: * [OC-12] (CP-100) UCO's idea of "Open vocabulary" does not agree with its implementation with owl:oneOf * RDFLib/pySHACL#127 Signed-off-by: Alex Nelson <[email protected]>
ashleysommer
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series addresses Issue 126.