Update routes to limit range to 30 days

[mpgxvii]

• Fix hrv, breathing rate, and skin temp routes to limit request date range to 30 days
• Solves Limit the date range of Fitbit requests #117

[yatharthranjan]

Please find a comment below. Can you also add the link to the documentation that states a limit of 30 days on these endpoints?

[yatharthranjan]

I would rename this to THIRTY_DAYS and put it in the top level class, then it can be returned in downstream classes getDateRangeInterval() function. That way you don't have to define it more than once and make the code more readable.

[yatharthranjan]

From what i can see, seems like we don't request for more than 30 days in a single request anyways?

[yatharthranjan]

LGTM (let's do some final testing in stage).

[mpgxvii]

From what i can see, seems like we don't request for more than 30 days in a single request anyways?

Oh I was thinking if the start date was > than 30 days before today, it would be the case? One of the users reported these logs:

WARN Failed to make request FitbitRestRequest{url=https://api.fitbit.com/1/user/[]/hrv/date/2023-04-19/2024-03-05/all.json, user=LocalUser{id='[]', version='2023-04-20T14:00:27.807529715Z

[yatharthranjan]

oh ok, could be the case. But we also see these same logs in our connector (which is not collecting any of these endpoints), so not sure what causes it. Maybe we need better reporting of failed requests in the logs (like the code, message, etc returned from failed HTTP request to determine the root cause).

This is a worthy feature update regardless, so i would proceed to merge.