Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checking of empty env var in kafka-wait #22

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

yatharthranjan
Copy link
Member

Problem

The temp file was not being created

Solution

check if the variable is empty, rather than "not empty" for creating temp file.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@yatharthranjan yatharthranjan merged commit 8c0ce26 into master Mar 23, 2023
@yatharthranjan yatharthranjan deleted the kafka-wait-patch branch March 23, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants