Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

746 project admin cannot access any project #747

Merged
merged 2 commits into from
Jan 8, 2024
Merged

746 project admin cannot access any project #747

merged 2 commits into from
Jan 8, 2024

Conversation

Bdegraaf1234
Copy link
Collaborator

@Bdegraaf1234 Bdegraaf1234 commented Jan 2, 2024 •
edited
Loading

Description: Remove redundant authCheck as the results of the query are filtered using the permissions of the logged in user anyway.

Fixes #746

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@Bdegraaf1234 Bdegraaf1234 linked an issue Jan 2, 2024 that may be closed by this pull request
Project admin cannot access any project #746
Closed
@Bdegraaf1234 Bdegraaf1234 changed the base branch from master to dev January 2, 2024 11:51
@Bdegraaf1234
Copy link
Collaborator Author

The first commit is just removing all redundant open modifiers, all "real"changes are in the second commit.

@Bdegraaf1234 Bdegraaf1234 self-assigned this Jan 2, 2024
@Bdegraaf1234 Bdegraaf1234 merged commit 6614430 into dev Jan 8, 2024
6 of 8 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the 746-project-admin-cannot-access-any-project branch February 23, 2024 14:43
@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peyman-mohtashami peyman-mohtashami peyman-mohtashami approved these changes

@nivemaham nivemaham Awaiting requested review from nivemaham

Assignees

@Bdegraaf1234 Bdegraaf1234

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project admin cannot access any project
2 participants
@Bdegraaf1234 @peyman-mohtashami