722 wait no longer needed in cypress tests

[Bdegraaf1234]

Description: Remove unneeded wait commands from cypress tests

Fixes #722

Checklist:

• The Main workflow has succeeded
• The Gatling tests have passed
• I have logged into the portal running locally with default admin credentials
• I have updated the README files if this change requires documentation update
• I have commented my code, particularly in hard-to-understand areas

[Bdegraaf1234]

Unfortunately, it seems that the need for wait is not removed.

One way to achieve non-arbitrary wait times would be to add guards by intercepting the xhr requests.

cy.intercept("GET", "/api/projects/radar/subjects?size=20&sort=login,desc").as("sort")
cy.get('jhi-subjects #order-by-desc').click();
cy.wait("@sort");

However, this seems like quite a bit more work and the wait times are not that long. I have also failed to find the logic in where the wait commands are needed.

I was able to remove three out of 4 without causing problems here.

[blootsvoets]

Failed tests with a lot of try / retry probably will still need the original wait. Once fixed, can this be merged or is it still WIP?

[Bdegraaf1234]

Turned out to be pretty small changes, I left the alternative wait strategy in with a comment. ready for review

[blootsvoets]

LGTM