Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #130 #160

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Implement #130 #160

merged 1 commit into from
Nov 1, 2022

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Oct 24, 2022

Only create new file version if OCR result was not empty

Signed-off-by: Robin Windey [email protected]

@R0Wi R0Wi linked an issue Oct 24, 2022 that may be closed by this pull request
Only create new file version if OCR result was not empty

Signed-off-by: Robin Windey <[email protected]>
@R0Wi R0Wi force-pushed the feature/impl#130 branch from 22d8088 to b33bcbe Compare October 24, 2022 16:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #160 (aa2430a) into master (8cf95ef) will not change coverage.
The diff coverage is 100.00%.

❗ Current head aa2430a differs from pull request most recent head b33bcbe. Consider uploading reports for the commit b33bcbe to get more accurate results

@@             Coverage Diff             @@
##              master      #160   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       165       166    +1     
===========================================
  Files             34        34           
  Lines            609       610    +1     
  Branches           4         4           
===========================================
+ Hits             609       610    +1     
Impacted Files Coverage Δ
lib/BackgroundJobs/ProcessFileJob.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@R0Wi R0Wi marked this pull request as ready for review October 24, 2022 17:07
@R0Wi R0Wi requested a review from bahnwaerter October 24, 2022 17:07
Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Feel free to merge the change.

@R0Wi R0Wi merged commit 8cfba2c into master Nov 1, 2022
R0Wi added a commit that referenced this pull request Nov 1, 2022
Only create new file version if OCR result was not empty

Signed-off-by: Robin Windey <[email protected]>

Signed-off-by: Robin Windey <[email protected]>
R0Wi added a commit that referenced this pull request Nov 1, 2022
Only create new file version if OCR result was not empty

Signed-off-by: Robin Windey <[email protected]>

Signed-off-by: Robin Windey <[email protected]>
@R0Wi R0Wi deleted the feature/impl#130 branch November 1, 2022 19:11
R0Wi added a commit that referenced this pull request Nov 1, 2022
Only create new file version if OCR result was not empty

Signed-off-by: Robin Windey <[email protected]>

Signed-off-by: Robin Windey <[email protected]>

Signed-off-by: Robin Windey <[email protected]>
R0Wi added a commit that referenced this pull request Nov 1, 2022
Only create new file version if OCR result was not empty

Signed-off-by: Robin Windey <[email protected]>

Signed-off-by: Robin Windey <[email protected]>

Signed-off-by: Robin Windey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Do not modify files that had no OCR done
2 participants