Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger on setting a tag #72

Closed
jkumeboshi opened this issue Nov 19, 2021 · 8 comments · Fixed by #74
Closed

trigger on setting a tag #72

jkumeboshi opened this issue Nov 19, 2021 · 8 comments · Fixed by #74
Assignees
Labels
backport stable22 enhancement New feature or request
Milestone

Comments

@jkumeboshi
Copy link

I think that trigger from a specific set of tags would be useful, to avoid to OCR any loaded PDF.

I would like to set a flow triggered by "ocr" tag, so I could:

  1. control which files are sent to OCR
  2. OCR also any already loaded files
@R0Wi
Copy link
Contributor

R0Wi commented Nov 20, 2021

Hi @jkumeboshi and thanks for this nice suggestion. I did a quick test and indeed the workflow engine is now possible to trigger workflows based on the Tag assigned event (when we first developed this app, that event wasn't yet available).

So yes we're looking forward to implement this feature. Just to pin the use-case:

  1. Create a new OCR workflow based on the event type Tag assigned with an arbitrary tag name
    image

  2. Tag the files you want to be processed with the matching tag used in step one by using the file details menu
    image

Expected result: the file will be added to the OCR queue and will be processed the next time NC cron runs.

@jkumeboshi is that how you would like it to work?


@bahnwaerter FYI some technical todos:

@R0Wi R0Wi self-assigned this Nov 20, 2021
@R0Wi R0Wi added backport stable22 enhancement New feature or request labels Nov 20, 2021
@jkumeboshi
Copy link
Author

yes, the use case is exactly what I expect (indeed I already tried that exact use case, hoping it was already working :) )

@R0Wi
Copy link
Contributor

R0Wi commented Nov 20, 2021

Shouldn't be too hard to implement this. I'd really appreciate if you volunteer to test this if it's ready 👍

@jkumeboshi
Copy link
Author

@R0Wi of course I can test it

R0Wi added a commit that referenced this issue Nov 21, 2021
R0Wi added a commit that referenced this issue Nov 21, 2021
R0Wi added a commit that referenced this issue Nov 21, 2021
@R0Wi R0Wi linked a pull request Nov 21, 2021 that will close this issue
4 tasks
@R0Wi
Copy link
Contributor

R0Wi commented Nov 21, 2021

@jkumeboshi @bahnwaerter a draft ist ready at https://github.com/R0Wi/workflow_ocr/suites/4422620243/artifacts/116982028. Would be nice if you could give me some feedback 👍

@jkumeboshi
Copy link
Author

I did many test this morning and works perfectly for me.
I'll use that test version by now, waiting an update in the app store.

@R0Wi
Copy link
Contributor

R0Wi commented Nov 22, 2021

Thanks for your feedback @jkumeboshi. You can track the progress at #74. We're working on that feature so we try to push it to the appstore these days.

@R0Wi
Copy link
Contributor

R0Wi commented Dec 4, 2021

FYI this is now officially included in v1.23.0 (Nextcloud 23) and v1.22.3 (Nextcloud 22), see https://apps.nextcloud.com/apps/workflow_ocr. Thank you all for contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable22 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants