fix: set default value of lint to false to improve the execution per… #7425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cba3161 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maiieul
previously requested changes
Mar 15, 2025
There was a problem hiding this comment.
@JerryWu1234 Imo we should change that default in the optimizer's vite.ts or plugin.ts, not in the starters.
it's fine right now |
shairez
approved these changes
Mar 25, 2025
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
Merged
shairez
reviewed
Mar 25, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'base': patch | |||
There was a problem hiding this comment.
just noticed this (I fixed it already in a different commit)
but for next time, please verify that this has a real package name or else it breaks the release
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…formance
What is it?
fixes #6837
related to 190
set default value of lint to false to improve the execution performance'
Description
Checklist
pnpm change