Skip to content

fix(rollup): improve manualChunks logic to minimize over-prefetching #7362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2025
Merged

fix(rollup): improve manualChunks logic to minimize over-prefetching #7362

merged 1 commit into from
Feb 22, 2025

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Feb 21, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner February 21, 2025 22:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3c4b87a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul force-pushed the fix-over-prefetching-2 branch from bd9d2ca to e4bf6e3 Compare February 21, 2025 22:42
@maiieul maiieul force-pushed the fix-over-prefetching-2 branch from e4bf6e3 to 3c4b87a Compare February 21, 2025 22:46
@maiieul maiieul changed the title fix(rollup): over-prefetching fix(rollup): improve manualChunks logic to minimize over-prefetching Feb 21, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 21, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7362

npm i https://pkg.pr.new/@builder.io/qwik-city@7362

npm i https://pkg.pr.new/eslint-plugin-qwik@7362

npm i https://pkg.pr.new/create-qwik@7362

commit: e4bf6e3

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview e4bf6e3

wmertens
wmertens approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 5e2a83a into QwikDev:main Feb 22, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiieul @wmertens