Skip to content

fix(starters): update turso createClient import, update turso docs note #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

A2-NieR
Copy link
Contributor

@A2-NieR A2-NieR commented Dec 30, 2024

What is it?

  • Bug
  • Docs

Description

Starting with a fresh turso integration, while working with a local sqlite db file the following error occured:

Internal server error: URL_SCHEME_NOT_SUPPORTED: The client that uses Web standard APIs supports only "libsql:", "wss:", "ws:", "https:" and "http:" URLs, got "file:". For more information, please read https://github.com/libsql/libsql-client-ts#supported-urls

Looking at the corresponding section in the turso docs shows the import of createClient must not be from @libsql/client/web since then it does not support file based urls.
This pr updates the import inside the turso starter and expands the note inside the docs explaining the issue.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@A2-NieR A2-NieR requested review from a team as code owners December 30, 2024 16:43
Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 1fb48f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @A2-NieR
Kudos for your first PR in this project 🎉

@gioboa gioboa enabled auto-merge (squash) December 30, 2024 17:20
@gioboa gioboa merged commit 1b5d1f0 into QwikDev:main Dec 30, 2024
18 checks passed
@A2-NieR
Copy link
Contributor Author

A2-NieR commented Dec 31, 2024

@gioboa dang, forgot to put my alias into the frontmatter section 😆

@A2-NieR A2-NieR deleted the fix/turso-import branch December 31, 2024 10:21
@github-actions github-actions bot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants