-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes ImageChrome option for FCS to users #503
Conversation
- Adds a shared items project for config files so they are visible in the Visual Studio solution explorer - Adds ImageChrome option to config files and LDSpectrogramRGB - Refactors LDSpectrogramRGB so that greyscale and FCS images output at the same size, and use common global constants - LDSpectrogramRGB will now save a chromeless image to disk if chromeless is requested (previously it would return just the chromeless image and save the chromed image to disk) Fixes #352
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
===========================================
+ Coverage 0.71% 43.45% +42.73%
===========================================
Files 481 481
Lines 48917 48918 +1
Branches 7662 7667 +5
===========================================
+ Hits 349 21255 +20906
+ Misses 48516 27663 -20853
+ Partials 52 0 -52
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerning your PR for unchromed images I have looked at the diffs and it all looks OK to me. I notice you have previously written an extention method for booleans, i.e. the .With extention. Also I wondered why not produce both chromed and unchromed images so the user does not have another choice to think about?
I have, but it was written when we first did chromeless images. It didn't change in this PR so you didn't see it. Good pick though. I also decided using just a boolean would be simpler in the config file. Am open to making the enum work there too but that can be done later.
scale, performance, etc.. e.g. when running AP on the HPC cluster, I want it to output exactly what I want. Writing extra files takes a lot of time and storage space |
Exposes ImageChrome option for FCS to users
Now users can suppress chrome output when doing index generation of when drawing false colour spectrograms.
Changes
Issues
Fixes #352
Visual Changes
Now when
ImageChrome
isfalse
in anLdSpectrogramConfig
, images with just raw spectral indices data will be shown.Final Checklist