Process extension #304
Merged
Process extension #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed warnings from `ExtensionsGeneral.cs` file - Extracted `ProcessExtensions` class to separate file - Return null when non windows computer attempts to retrieve parent process - Updated VSCode tasks
Allcharles
force-pushed
the
process-extension
branch
from
a772ad6 to
61d28f6
Compare
atruskie
requested changes
Mar 19, 2020
There was a problem hiding this comment.
The convention we want for extension classes is XXXExtensions. Rename to ExtensionsGeneral.cs to SystemExtensions.
It seems the tests failed The name 'GetParentProcess' does not exist in the current context. Probably because they're in #RELEASE and the code doesn't exist because of the macro.
lastly, add a test for MainEntry invocation
atruskie
approved these changes
Mar 19, 2020
atruskie
pushed a commit
that referenced
this pull request
Apr 2, 2020
* - Renamed `ExtensionsSystem.cs` to `ExtensionsGeneral.cs` - Removed warnings from `ExtensionsGeneral.cs` file - Extracted `ProcessExtensions` class to separate file - Return null when non windows computer attempts to retrieve parent process - Updated VSCode tasks * Addressing review comments Work done for #196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process Extension
Wrapped windows only software for retrieving parent process.
Changes
ExtensionsSystem.cstoExtensionsGeneral.csExtensionsGeneral.csfileProcessExtensionsclass to separate fileIssues