Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug at line259 in EventFilters.cs #466

Closed
towsey opened this issue Mar 30, 2021 · 3 comments
Closed

Bug at line259 in EventFilters.cs #466

towsey opened this issue Mar 30, 2021 · 3 comments
Assignees

Comments

@towsey
Copy link
Contributor

towsey commented Mar 30, 2021

Describe the bug

There is an attempt to write the contents of a List when there may be no elements in the list.

Expected behavior

Should only write the list if it contains at least one double.

Diagnostics

Lines 259 and 260 should be moved and inserted at current line 279 by which stage it has been established that the list contains values.

@atruskie
Copy link
Member

Pro tip: use the copy permalink option to insert a code snippet:

image

What ill effect does this bug have?

In general, I'm against altering behaviour for special cases. If a list is empty than the debug line should print an empty list (or an "<empty>" sentinel value).

towsey added a commit that referenced this issue Mar 30, 2021
@towsey
Copy link
Contributor Author

towsey commented Apr 9, 2021

I shifted the two lines of code to where they should be, since there is no point writing something irrelevant to log.

@towsey towsey mentioned this issue Apr 9, 2021
5 tasks
@atruskie
Copy link
Member

atruskie commented Apr 9, 2021

Closed by #475

@atruskie atruskie closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants