-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default FFT window #291
Comments
Can you show the effect of the different window function please? Add a couple of pictures into the response. We'll go ahead with this change but after .Net Core branch is merged in |
I have run both Hanning and Hamming windows on a frequently used test recording from Hendra Brisbane and can see no difference between the resulting spectrograms. So it would appear that the major difference arises only for recordings that have been resampled either up or down. Due to the significant difference in the resampled situation, I therefore propose that we switch to HANNING window as default. This may or may not result in a number of breaking unit tests depending on how many use a resampled signal. |
Issue #291 Have set the default FFT window to Hanning for calculation of all summary and spectral indices. However left the Test methods using HAMMING window so do not have to make changes to the output.
Issue #291 Change from Hamming to Hanning window casuses significant differences in dB values - more than be adjusted for by chaning test sensitivity.
Issue #291 Have set the default FFT window to Hanning for calculation of all summary and spectral indices. However left the Test methods using HAMMING window so do not have to make changes to the output.
Issue #291 Change from Hamming to Hanning window casuses significant differences in dB values - more than be adjusted for by chaning test sensitivity.
Currently the default FFT window is the Hamming window.
This default is set in the class SpectrogramSettings at line 29:
public string WindowFunction { get; set; } = WindowFunctions.HAMMING.ToString();
Recent experience indicates that this window is not as good as the Hanning window.
The default should be change d to Hanning. However, because the FFT window is used early in the signal processing sequence, this change may cause multiple tests to fail.
The text was updated successfully, but these errors were encountered: