Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove R3D as spectral index #276

Closed
towsey opened this issue Nov 24, 2019 · 4 comments
Closed

Remove R3D as spectral index #276

towsey opened this issue Nov 24, 2019 · 4 comments
Assignees

Comments

@towsey
Copy link
Contributor

towsey commented Nov 24, 2019

Removing R3D as spectral index because it does not add anything useful to the spectral indices that we already have. It did not work as I originally expected it to.

towsey added a commit that referenced this issue Nov 25, 2019
Issue #276  Removed all references to spectral index R3D and to calculation of it.
towsey added a commit that referenced this issue Nov 25, 2019
Issue #276 Removed references to R3D identified by Anthony
Also fixed two failed unit tests.
towsey added a commit that referenced this issue Nov 25, 2019
Issue #276 Fixed more broken tests as result of removing the R3D spectral index.
towsey added a commit that referenced this issue Nov 25, 2019
Issue #276 - fixed another two broken unit tests
@towsey
Copy link
Contributor Author

towsey commented Nov 25, 2019

The last edits have corrected all failed unit tests.

@atruskie
Copy link
Member

@towsey, yup I saw 👍, just waiting for the last CI build to finish

@atruskie
Copy link
Member

Closed in #277

@atruskie
Copy link
Member

atruskie commented Feb 3, 2020

Further context from @towsey:

The reason I removed R3D spectral is simply that it was not doing what I originally intended. It was calculated by averaging RHZ, RPS and RNG, that is, the horizontal, positive and negative slope ridges. It turned out to be highly influenced by and highly correlated with RVT (vertical ridges). If you wish to resurrect R3D, you can simply write an R script and average the RHZ, RPS and RNG matrices which are still calculated. Alternatively you could try to use one of those in place of the original R3D. I hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants