Skip to content
This repository has been archived by the owner on May 10, 2018. It is now read-only.

When non-latin keyboard layout is active, standard Ctrl+C/X/V combos don't work #1494

Closed
pfalcon opened this issue Oct 16, 2014 · 21 comments
Closed
Labels

Comments

@pfalcon
Copy link

pfalcon commented Oct 16, 2014

It always was like that, just tested on 1.9.0 (bcc9f3f) (current master).

So, when I have non-Latin keyboard active (Cyrillic in my case), pressing Ctrl+C or Ctrl+V in address line doesn't lead to normal Copy/Paste actions, but instead a Cyrillic letter corresponding to the key is input (as if Ctrl wasn't pressed). The keys also don't work under such conditions in HTML input fields, but their presses just ignored - no chars are input.

I have to say this is pretty critical issue for me, and probably for other folks who use non-Latin scripts. Qupzilla has a lot of things where it lacks comparing to big guys like Firefox and Chrome, and I personally run Qupzilla and Firefox in parallel, preferring Qupzilla, and on seeing an issue, switch to Firefox, and hopefully report the issue here. But with Copy/Paste not working, I can't even switch comfortably from Q to FF, so last week I find that I'm giving up on Qupzilla and try to open new pages in FF.

So, please don't lose yet another user ;-). (As usual, for any report received, there're hundreds of people who faced it and just gave up on the software, considering it's not even worth their time to report it.)

@pfalcon
Copy link
Author

pfalcon commented Oct 16, 2014

So, just to state the obvious, Firefox, Chrome, and most of the other well-known production software is not affected by such issue.

To try Qt stuff, I installed Arora 0.11, and it's not affected either.

The issues happens for me in Qt 5.2.1 build of Qupzilla.

@ghost
Copy link

ghost commented Oct 17, 2014

I have no problem with that.

QupZilla 1.9.0 (1a54cda705)
Qt 4.8.5
QtWebKit 537.21

So, as you already mentioned, that's an Qt 5 issue perhaps.

@pejakm
Copy link
Member

pejakm commented Oct 17, 2014

@pfalcon and @cranes-bill: This is Qt5 issue (I'm affected, too, and yes, it's damn annoying). Perhaps there's a way to workaround this bug, @nowrep?

@pejakm pejakm added the Qt label Oct 17, 2014
@pejakm
Copy link
Member

pejakm commented Oct 17, 2014

At the same time, it is not reproducible in QtTestBrowser. Perhaps this is a bug, after all?

@nowrep
Copy link
Member

nowrep commented Oct 17, 2014

In QtTestBrowser, the shortcuts (Ctrl+C/V/X) works only in webview (not in url bar). But Ctrl+A is not working.
I'm investigating the issue why the shortcuts are not working in webview in QupZilla. But I am afraid that's as far as I will be able to do with this problem.

@pfalcon
Copy link
Author

pfalcon commented Oct 17, 2014

Thanks for confirming it's Qt5 issue - ironically, I strived to use it, hoping that it will give better QtWebkit, but it doesn't really, but gives other problems...

So, is there reference to upstream bug I can monitor/comment on?

Also, sorry for giving dummy's obvious comment (as I know little of both Qt and Qupzilla), but for me this issue looks like making an accelerator check too late (when a keycode is already translated to char), or likely, Qt's key event has both fields ("keycode" and "char") right away, so it's the matter of using the right one. I understand that code which handles accelerators may be buried deep in Qt, but hopefully it can be overriden and whole issue fixable.

Thanks!

@pejakm
Copy link
Member

pejakm commented Oct 17, 2014

So, is there reference to upstream bug I can monitor/comment on?

I tried searching for it this morning, but had no luck. Perhaps it's not reported yet. @JHooverman, any chance you could give a try?

@JHooverman
Copy link
Member

@mladen: I will have a look into the qt bug-reports. Could you please add your qt and qtwebkit version?
@pfalcon: Your arora-0.11 is compiled/ linked against qt4? Please confirm.

@pfalcon
Copy link
Author

pfalcon commented Oct 17, 2014

@JHooverman, yes, it's standard Ubuntu package, using qt4 4.8.6 (again, standard ubuntu package).

The reason I'm building Qupzilla against qt5 (which is so far still standard ubuntu 14.04 package) is to get better qtwebkit, to have progress on other issues I reported (#1445, #1448).

@ghost
Copy link

ghost commented Oct 17, 2014

I can propose a sample workaround: Just compile and install Qt4 to /opt/qt for example, then compile and use Qupzilla with it!

@nowrep nowrep closed this as completed in f6b6795 Oct 17, 2014
@nowrep nowrep added Bug and removed Qt labels Oct 17, 2014
@pejakm
Copy link
Member

pejakm commented Oct 17, 2014

Fantastic job, it works now! :) Браво!!!

@JHooverman
Copy link
Member

Does it work in webview and url-bar?

@pfalcon
Copy link
Author

pfalcon commented Oct 17, 2014

Indeed, thnaks for quick fix. But for me it started to work in html input fields, but still doesn't work with url-bar.

@JHooverman
Copy link
Member

@ALL: This seems to be a known Qt-Bug, which should have been fixed already (pull request created). Please have a look here.

@pfalcon
Copy link
Author

pfalcon commented Oct 17, 2014

Thanks for the find. Except the fix was abandoned couple of times for 5.3.x, and still not merged into 5.4: https://codereview.qt-project.org/#/c/94403/

@JHooverman
Copy link
Member

Since the priority of QTBUG-32274 is set to P2: important, the fix will hopefully merged soon.

@pfalcon
Copy link
Author

pfalcon commented Oct 17, 2014

Yeah, and I'd like repeat my previous kind request - if any of Qupzilla developers can give hints/info/references on how to build Qt+QtWebKit from source and then build Qupzilla against it, it would be much appreciated (I can test/elaborate it and put on the wiki for other folks to reuse).

@nowrep
Copy link
Member

nowrep commented Oct 17, 2014

I will fix the issue for locationbar / searchbar.
But I probably won't fix it for all inputs, that's for Qt guys to fix.

@JHooverman
Copy link
Member

@pfalcon: I have added a comment in #1448, 28.9., which contains a link about how to build qt from git. Did this not help you?

@nowrep
Copy link
Member

nowrep commented Oct 17, 2014

@pfalcon You can also use nightly builds for Linux from http://download.qt-project.org/snapshots/qt/5.4/5.4.0-beta/

@pfalcon
Copy link
Author

pfalcon commented Oct 17, 2014

@JHooverman: Ah, I was traveling at that time and missed the details. Started git clone now.

@nowrep: Thanks, that's helpful too, but guess I bite the bullet and try to have a setup suitable for hacking on all that stuff ;-).

nowrep added a commit that referenced this issue Oct 18, 2014
…ayout

This fixes Ctrl+C/V/X/A shortcuts in LocationBar and WebSearchBar

Followup to #1494
nowrep added a commit that referenced this issue Oct 18, 2014
…ayout

This fixes Ctrl+C/V/X/A shortcuts in LocationBar and WebSearchBar

Followup to #1494
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants