-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device identity #383
device identity #383
Conversation
only error is: |
pylint complains about changes not related to this PR |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111601-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 199 fixed
Unstable tests
|
qubesmanager/settings.py
Outdated
ass = device_protocol.DeviceAssignment( | ||
device_protocol.Port( | ||
self.vm.app.domains['dom0'], dev.port_id, 'pci'), | ||
mode='required', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not match new DeviceAssignment constructor after QubesOS/qubes-core-admin-client@8772108#diff-3c9f34f047553a6c2bc231786134cfece1c2d94ba3931a216f6a91840e130e95L860-R1015
Maybe you want to use the DeviceAssignment.new helper here?
See 338c5ed, there is also an issue with listing assigned devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is seems to work good enough, together with #395, lets handle minor issues in follow up PRs
implements QubesOS/qubes-issues/issues/9325