Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build 2024110718-4.3] openQA test fails in clipboard_and_web with sys-gui #9564

Closed
marmarek opened this issue Nov 8, 2024 · 3 comments · Fixed by QubesOS/qubes-gui-daemon#154
Assignees
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: gui-domain C: gui-virtualization diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.

Comments

@marmarek
Copy link
Member

marmarek commented Nov 8, 2024

Observation

openQA test in scenario qubesos-4.3-pull-requests-x86_64-system_tests_guivm_gui_interactive@64bit fails in
clipboard_and_web

Copy notification does not appear. Logs suggest copy didn't happened at all.

Test suite description

Reproducible

Fails since (at least) Build 2024110603-4.3

Expected result

Last good: 2024110421-4.3 (or more recent)

Further details

Always latest result in this scenario: latest

@marmarek marmarek added T: bug C: gui-virtualization C: gui-domain P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Nov 8, 2024
@marmarek
Copy link
Member Author

marmarek commented Nov 8, 2024

Ah, I know, gui-daemon in dom0 intercepted the copy key sequence. This is because it didn't got option to ignore it:

qvm-start-daemon: sys-gui: Ignoring invalid feature:
gui-secure-copy-sequence=none
qvm-start-daemon: sys-gui: Ignoring invalid feature:
gui-secure-paste-sequence=none

@alimirjamali
Copy link

alimirjamali commented Nov 8, 2024

Ah, I know, gui-daemon in dom0 intercepted the copy key sequence. This is because it didn't got option to ignore it:

I see. The parse_key_sequence procedure within xside.c does not exit on invalid key sequences and just disables it (also related to my recent closed issue #9561).

@alimirjamali
Copy link

alimirjamali commented Nov 8, 2024

Validator is fixed to allow none and disable. I will submit a patch to xside.c to log a meaningful message on those values.

@andrewdavidwong andrewdavidwong added needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. affects-4.3 This issue affects Qubes OS 4.3. labels Nov 8, 2024
marmarek added a commit to QubesOS/qubes-gui-daemon that referenced this issue Nov 21, 2024
* origin/pr/154:
  Handle `disable` & `none` for secure copy/paste

Pull request description:

resolves: QubesOS/qubes-issues#9564
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: gui-domain C: gui-virtualization diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants