Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSG_TRIGGER_SERVICE3 and MSG_TRIGGER_SERVICE behave inconsistently on invalid service names #9098

Closed
DemiMarie opened this issue Apr 7, 2024 · 0 comments · Fixed by QubesOS/qubes-core-qrexec#139
Closed

MSG_TRIGGER_SERVICE3 and MSG_TRIGGER_SERVICE behave inconsistently on invalid service names #9098

DemiMarie opened this issue Apr 7, 2024 · 0 comments · Fixed by QubesOS/qubes-core-qrexec#139
Assignees
@DemiMarie
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.

Comments

@DemiMarie
Copy link

DemiMarie commented Apr 7, 2024 •
edited
Loading

How to file a helpful issue

Qubes OS release

R4.2. R4.1 doesn’t have the check at all so there is nothing to be inconsistent about.

Brief summary

MSG_TRIGGER_SERVICE3 and MSG_TRIGGER_SERVICE behave inconsistently on invalid service names (empty or start with a +)

Steps to reproduce

Implement a qrexec agent that sends an old-style MSG_TRIGGER_SERVICE request with a name that starts with NUL or +.

Expected behavior

Qrexec policy engine not invoked with this invalid name, as would happen if MSG_TRIGGER_SERVICE3 was used.

Actual behavior

Qrexec policy engine invoked with this invalid name.
@DemiMarie DemiMarie added T: bug C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. labels Apr 7, 2024
@DemiMarie DemiMarie self-assigned this Apr 7, 2024
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue Apr 7, 2024
@DemiMarie
Forbid empty service names in legacy MSG_TRIGGER_SERVICE
2223c11 
There is no point in allowing calls with an empty service name: if the
argument was empty, the call would be unconditionally rejected by the
policy daemon, and even if it was _not_ empty, libqrexec would refuse to
execute the call.  Furthermore, MSG_TRIGGER_SERVICE3 already checks for
empty service names and sends MSG_SERVICE_REFUSED without even querying
the policy daemon, so querying the policy daemon for MSG_TRIGGER_SERVICE
is inconsistent.

Fixes: QubesOS/qubes-issues#9098
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue Apr 7, 2024
@DemiMarie
Forbid empty service names in legacy MSG_TRIGGER_SERVICE
4966ff3 
There is no point in allowing calls with an empty service name: if the
argument was empty, the call would be unconditionally rejected by the
policy daemon, and even if it was _not_ empty, libqrexec would refuse to
execute the call.  Furthermore, MSG_TRIGGER_SERVICE3 already checks for
empty service names and sends MSG_SERVICE_REFUSED without even querying
the policy daemon, so querying the policy daemon for MSG_TRIGGER_SERVICE
is inconsistent.

Fixes: QubesOS/qubes-issues#9098
@DemiMarie DemiMarie mentioned this issue Apr 7, 2024
Merged
@andrewdavidwong andrewdavidwong added the affects-4.2 This issue affects Qubes OS 4.2. label Apr 8, 2024
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue Apr 8, 2024
@DemiMarie
Forbid empty service names in legacy MSG_TRIGGER_SERVICE
8a1cbe4 
There is no point in allowing calls with an empty service name: if the
argument was empty, the call would be unconditionally rejected by the
policy daemon, and even if it was _not_ empty, libqrexec would refuse to
execute the call.  Furthermore, MSG_TRIGGER_SERVICE3 already checks for
empty service names and sends MSG_SERVICE_REFUSED without even querying
the policy daemon, so querying the policy daemon for MSG_TRIGGER_SERVICE
is inconsistent.

Fixes: QubesOS/qubes-issues#9098
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue Apr 9, 2024
@DemiMarie
Forbid empty service names in legacy MSG_TRIGGER_SERVICE
c230785 
There is no point in allowing calls with an empty service name: if the
argument was empty, the call would be unconditionally rejected by the
policy daemon, and even if it was _not_ empty, libqrexec would refuse to
execute the call.  Furthermore, MSG_TRIGGER_SERVICE3 already checks for
empty service names and sends MSG_SERVICE_REFUSED without even querying
the policy daemon, so querying the policy daemon for MSG_TRIGGER_SERVICE
is inconsistent.

Fixes: QubesOS/qubes-issues#9098
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue Apr 9, 2024
@DemiMarie
Forbid empty service names in legacy MSG_TRIGGER_SERVICE
4684bd6 
There is no point in allowing calls with an empty service name: if the
argument was empty, the call would be unconditionally rejected by the
policy daemon, and even if it was _not_ empty, libqrexec would refuse to
execute the call.  Furthermore, MSG_TRIGGER_SERVICE3 already checks for
empty service names and sends MSG_SERVICE_REFUSED without even querying
the policy daemon, so querying the policy daemon for MSG_TRIGGER_SERVICE
is inconsistent.

Fixes: QubesOS/qubes-issues#9098
This was referenced May 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DemiMarie DemiMarie

Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various bugfixes DemiMarie/qubes-core-qrexec
2 participants
@DemiMarie @andrewdavidwong