Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI option to updater GUI to immediately start updating selected VMs #8355

Closed
marmarta opened this issue Jul 12, 2023 · 4 comments · Fixed by QubesOS/qubes-desktop-linux-manager#170
Assignees
Labels
C: manager/widget C: updates P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.
Milestone

Comments

@marmarta
Copy link
Member

marmarta commented Jul 12, 2023

The problem you're addressing (if any)

There are multiple ways we do updates in different GUI tools: updater widget runs qubes-update-gui, while manager uses either qubes-dom0-update or qubes.InstallUpdatesGUI service. It would be much easier to have a simple unified way to do this.

The solution you'd like

it would be good to have a command-line option to run updates for selected qubes in the qubes-update-gui, e.g. --qube that accepts one or more qube names. Updater started with this option should start updating selected qubes immediately.

The value to a user, and who that user might be

Improved error reporting and more consistent system behavior.

references #8117

@marmarta marmarta added T: enhancement P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Jul 12, 2023
@andrewdavidwong
Copy link
Member

There are multiple ways we do updates in different GUI tools: updater widget runs qubes-update-gui, while manager uses either qubes-dom0-update or qubes.InstallUpdatesGUI service. It would be much easier to have a simple unified way to do this.

That's #6635, isn't it?

it would be good to have a command-line option to run updates for selected qubes in the qubes-update-gui, e.g. --qube that accepts one or more qube names. Updater started with this option should start updating selected qubes immediately.

Hm, I don't see how this addresses the problem. Introducing a new command-line tool option doesn't affect users who update via either of the GUI methods.

Maybe the unstated part is that, once this new command-line option is implemented, you plan to use it behind the scenes in order to implement #6635?

Or is there something else I'm missing?

@andrewdavidwong andrewdavidwong added this to the Release TBD milestone Jul 13, 2023
@andrewdavidwong
Copy link
Member

Add a CLI option to updater GUI [...]

I could be wrong, but this sounds like an oxymoron to me, because GUIs don't have CLI options.

@andrewdavidwong
Copy link
Member

Oh wait, I think I'm starting to get it now. It's a CLI option for starting the GUI and running it in a certain mode.

@marmarta
Copy link
Member Author

Oh wait, I think I'm starting to get it now. It's a CLI option for starting the GUI and running it in a certain mode.

yeah, exactly - it would be nice for starting updates from e.g. qube manager

piotrbartman added a commit to piotrbartman/qubes-desktop-linux-manager that referenced this issue Jul 19, 2023
implements QubesOS/qubes-issues#8355
Now it is possible to start gui updater with cli options.
If you chose directly which vms should be updated introPage will be skipped.
If you run updater with explicitly given option this will override option in settings.
@andrewdavidwong andrewdavidwong modified the milestones: Release TBD, Release 4.2 Jul 19, 2023
@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Jul 19, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.2 milestone Aug 13, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: manager/widget C: updates P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants