Disk space widget crashes / fails to start, if it can't get information about one of the pools #8187

marmarek · 2023-05-08T02:09:13Z

Qubes OS release

R4.2 (could affect R4.1 too)

Brief summary

Disk space widget crashes / fails to start, if it can't get information about one of the pools

Steps to reproduce

Have a storage pool on removable disk (or, in a loop-mounted file like it was in my case)
Disconnect that disk
Try starting gui-disk-space

In this case, if there was any qube in that pool it won't start of course. But for the widget to crash, there don't need to be any qube in that storage pool at all, it can be an empty pool.

Expected behavior

It starts successfully, but either list the pool with "unknown" free space, or not list it at all.

Actual behavior

May 07 22:03:13 dom0 widget-wrapper[142232]: Traceback (most recent call last):
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/bin/qui-disk-space", line 33, in <module>
May 07 22:03:13 dom0 widget-wrapper[142232]:     sys.exit(load_entry_point('qui==0.1', 'gui_scripts', 'qui-disk-space')())
May 07 22:03:13 dom0 widget-wrapper[142232]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qui/tray/disk_space.py", line 472, in main
May 07 22:03:13 dom0 widget-wrapper[142232]:     app = DiskSpace()
May 07 22:03:13 dom0 widget-wrapper[142232]:           ^^^^^^^^^^^
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qui/tray/disk_space.py", line 321, in __init__
May 07 22:03:13 dom0 widget-wrapper[142232]:     self.refresh_icon()
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qui/tray/disk_space.py", line 328, in refresh_icon
May 07 22:03:13 dom0 widget-wrapper[142232]:     pool_data = PoolUsageData(self.qubes_app)
May 07 22:03:13 dom0 widget-wrapper[142232]:                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qui/tray/disk_space.py", line 155, in __init__
May 07 22:03:13 dom0 widget-wrapper[142232]:     self.__populate_pools()
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qui/tray/disk_space.py", line 164, in __populate_pools
May 07 22:03:13 dom0 widget-wrapper[142232]:     if not getattr(pool, 'size', None) or \
May 07 22:03:13 dom0 widget-wrapper[142232]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qubesadmin/storage.py", line 375, in size
May 07 22:03:13 dom0 widget-wrapper[142232]:     return int(self.usage_details['data_size'])
May 07 22:03:13 dom0 widget-wrapper[142232]:                ^^^^^^^^^^^^^^^^^^
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qubesadmin/storage.py", line 341, in usage_details
May 07 22:03:13 dom0 widget-wrapper[142232]:     pool_usage_data = self.app.qubesd_call(
May 07 22:03:13 dom0 widget-wrapper[142232]:                       ^^^^^^^^^^^^^^^^^^^^^
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qubesadmin/app.py", line 765, in qubesd_call
May 07 22:03:13 dom0 widget-wrapper[142232]:     return self._parse_qubesd_response(return_data)
May 07 22:03:13 dom0 widget-wrapper[142232]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
May 07 22:03:13 dom0 widget-wrapper[142232]:   File "/usr/lib/python3.11/site-packages/qubesadmin/base.py", line 111, in _parse_qubesd_response
May 07 22:03:13 dom0 widget-wrapper[142232]:     raise exc_class(format_string, *args)
May 07 22:03:13 dom0 widget-wrapper[142232]: qubesadmin.exc.StoragePoolException: cannot open 'testpool': no such pool

The text was updated successfully, but these errors were encountered:

Make only one statvfs() call to get consistent information for size and usage. Also handle an absent pool correctly by returning an empty dict for usage_details() and None for usage() and size(), instead of raising FileNotFoundError. QubesOS/qubes-issues#8187 QubesOS/qubes-issues#8188

Make only one statvfs() call to get consistent size and usage information. Also handle an absent pool correctly by returning an empty dict for usage_details() and None for size() and usage() instead of raising FileNotFoundError. QubesOS/qubes-issues#8187 QubesOS/qubes-issues#8188

Wrap pool access in intermediary object to catch all possible exceptions. Cleanup for more readability. fixes QubesOS/qubes-issues#8187

qubesos-bot · 2023-05-29T17:41:53Z

Automated announcement from builder-github

The package desktop-linux-manager has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot · 2023-05-29T17:50:29Z

Automated announcement from builder-github

The package desktop-linux-manager has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot · 2023-05-29T18:03:31Z

Automated announcement from builder-github

The package desktop-linux-manager has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

qubesos-bot · 2023-05-29T19:42:52Z

Automated announcement from builder-github

The component desktop-linux-manager (including package desktop-linux-manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

qubesos-bot · 2023-05-29T19:48:16Z

Automated announcement from builder-github

The component desktop-linux-manager (including package desktop-linux-manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

qubesos-bot · 2023-05-29T19:57:46Z

Automated announcement from builder-github

The component desktop-linux-manager (including package desktop-linux-manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

qubesos-bot · 2023-07-01T20:56:23Z

Automated announcement from builder-github

The package desktop-linux-manager has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot · 2023-07-01T20:57:19Z

Automated announcement from builder-github

The package desktop-linux-manager has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot · 2023-07-01T20:57:41Z

Automated announcement from builder-github

The package desktop-linux-manager has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot · 2023-07-01T21:11:55Z

Automated announcement from builder-github

The component desktop-linux-manager (including package desktop-linux-manager) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

qubesos-bot · 2023-07-01T21:12:18Z

Automated announcement from builder-github

The component desktop-linux-manager (including package desktop-linux-manager) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

qubesos-bot · 2023-07-01T21:12:41Z

Automated announcement from builder-github

The component desktop-linux-manager (including package desktop-linux-manager) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

Make only one statvfs() call to get consistent size and usage information. Also handle an absent pool correctly by returning an empty dict for usage_details() and None for size() and usage() instead of raising FileNotFoundError. QubesOS/qubes-issues#8187 QubesOS/qubes-issues#8188 (cherry picked from commit 2deb827)

marmarek added T: bug C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels May 8, 2023

marmarek added this to the Release 4.2 milestone May 8, 2023

marmarek mentioned this issue May 8, 2023

qvm-pool ls crashes if it can't get info about some pool #8188

Open

andrewdavidwong added needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: storage labels May 8, 2023

andrewdavidwong assigned marmarta May 8, 2023

rustybird mentioned this issue May 8, 2023

reflink: implement usage_details(), handle absent pool QubesOS/qubes-core-admin#535

Merged

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue May 12, 2023

More resilient qui-disk-space widget

187f252

Wrap pool access in intermediary object to catch all possible exceptions. Cleanup for more readability. fixes QubesOS/qubes-issues#8187

marmarta mentioned this issue May 12, 2023

More resilient qui-disk-space widget QubesOS/qubes-desktop-linux-manager#154

Merged

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue May 23, 2023

More resilient qui-disk-space widget

fa5ada9

Wrap pool access in intermediary object to catch all possible exceptions. Cleanup for more readability. fixes QubesOS/qubes-issues#8187

qubesos-bot mentioned this issue May 24, 2023

core-admin v4.2.11 (r4.2) QubesOS/updates-status#3763

Closed

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue May 25, 2023

More resilient qui-disk-space widget

546230b

Wrap pool access in intermediary object to catch all possible exceptions. Cleanup for more readability. fixes QubesOS/qubes-issues#8187

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue May 26, 2023

More resilient qui-disk-space widget

da3c457

Wrap pool access in intermediary object to catch all possible exceptions. Cleanup for more readability. fixes QubesOS/qubes-issues#8187

marmarek closed this as completed in QubesOS/qubes-desktop-linux-manager@a4cadc5 May 29, 2023

qubesos-secondary-bot mentioned this issue May 29, 2023

desktop-linux-manager v4.2.7 (r4.2) QubesOS/updates-status#3769

Closed

qubesos-bot added the r4.2-vm-bullseye-cur-test label May 29, 2023

qubesos-bot added the r4.2-vm-bookworm-cur-test label May 29, 2023

qubesos-bot added the r4.2-vm-centos-stream8-cur-test label May 29, 2023

qubesos-bot added the r4.2-host-cur-test label May 29, 2023

qubesos-bot added the r4.2-vm-fc36-cur-test label May 29, 2023

qubesos-bot added the r4.2-vm-fc37-cur-test label May 29, 2023

qubesos-bot added the r4.2-vm-fc38-cur-test label May 29, 2023

qubesos-bot added r4.2-vm-centos-stream8-stable and removed r4.2-vm-centos-stream8-cur-test labels Jul 1, 2023

qubesos-bot added r4.2-vm-bullseye-stable and removed r4.2-vm-bullseye-cur-test labels Jul 1, 2023

qubesos-bot added r4.2-vm-bookworm-stable r4.2-host-stable and removed r4.2-vm-bookworm-cur-test r4.2-host-cur-test labels Jul 1, 2023

qubesos-bot added r4.2-vm-fc36-stable and removed r4.2-vm-fc36-cur-test labels Jul 1, 2023

qubesos-bot added r4.2-vm-fc37-stable and removed r4.2-vm-fc37-cur-test labels Jul 1, 2023

qubesos-bot added r4.2-vm-fc38-stable and removed r4.2-vm-fc38-cur-test labels Jul 1, 2023

qubesos-bot mentioned this issue Jul 4, 2023

core-admin v4.1.32 (r4.1) QubesOS/updates-status#3849

Closed

andrewdavidwong added the affects-4.2 This issue affects Qubes OS 4.2. label Aug 8, 2023

tasket mentioned this issue Aug 8, 2023

Qubes widgets should work properly in Xwayland #8410

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disk space widget crashes / fails to start, if it can't get information about one of the pools #8187

Disk space widget crashes / fails to start, if it can't get information about one of the pools #8187

marmarek commented May 8, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

Disk space widget crashes / fails to start, if it can't get information about one of the pools #8187

Disk space widget crashes / fails to start, if it can't get information about one of the pools #8187

Comments

marmarek commented May 8, 2023

Qubes OS release

Brief summary

Steps to reproduce

Expected behavior

Actual behavior

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented May 29, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023

qubesos-bot commented Jul 1, 2023