Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qubes-vm-settings does not change color of qube if tab is changed before pressing OK #7990

Closed
jamke opened this issue Jan 17, 2023 · 14 comments · Fixed by QubesOS/qubes-manager#335
Closed

qubes-vm-settings does not change color of qube if tab is changed before pressing OK #7990

jamke opened this issue Jan 17, 2023 · 14 comments · Fixed by QubesOS/qubes-manager#335
Assignees
@marmarta
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-dom0-stable r4.1-fc36-cur-test r4.1-fc37-stable r4.1-fc38-stable r4.2-host-cur-test r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc36-stable r4.2-vm-fc37-stable
Milestone
Release 4.1 updates

Comments

@jamke
Copy link

jamke commented Jan 17, 2023

How to file a helpful issue

Qubes OS release

R4.1. But I had it on R4.0 for sure, maybe before that too.

Brief summary

qubes-vm-settings does not change color of qube if tab is changed before pressing OK.

Steps to reproduce

  1. run qubes-vm-settings someqube
  2. change color from the combobox
  3. change current tab, e.g. click Advanced tab at the top
  4. press OK button

Expected behavior

The color of qube has been changed.

Actual behavior

The color of qube has not been changed.
@jamke jamke added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug labels Jan 17, 2023
@andrewdavidwong andrewdavidwong added C: manager/widget needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jan 18, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.1 updates milestone Jan 18, 2023
@marmarta marmarta mentioned this issue Feb 2, 2023
Merged
This was referenced Feb 17, 2023
Closed
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Feb 17, 2023
@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek marmarek added the backport pending On closed issues, indicates fix released for newer version will be backported to older version. label Jun 22, 2023
marmarek pushed a commit to QubesOS/qubes-manager that referenced this issue Jun 22, 2023
@marmarta @marmarek
Fix detecting if widget was changed in VM settings
4c429ef 
Instead of checking for isVisible, which can fail if
we are on a different tab, check for isEnabled (also
added appropriate disable commands where widget should
be disabled).

fixes QubesOS/qubes-issues#7990

(cherry picked from commit ae5d2fb)
@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package qubes-manager-4.1.29-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Jun 22, 2023
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-manager_4.1.29-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Jul 1, 2023
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-manager_4.1.30-1+deb10u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package qubes-manager-4.1.30-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
@marmarek marmarek removed the backport pending On closed issues, indicates fix released for newer version will be backported to older version. label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmarta marmarta

Labels
affects-4.1 This issue affects Qubes OS 4.1. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-dom0-stable r4.1-fc36-cur-test r4.1-fc37-stable r4.1-fc38-stable r4.2-host-cur-test r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc36-stable r4.2-vm-fc37-stable
Projects
None yet
Milestone
Release 4.1 updates
Development

Successfully merging a pull request may close this issue.

Fix detecting if widget was changed in VM settings marmarta/qubes-manager
5 participants
@marmarek @marmarta @andrewdavidwong @qubesos-bot @jamke