Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt-get error - E: Repository 'https://cdn-aws.deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'testing' to 'stable' #5149

Closed
adrelanos opened this issue Jul 7, 2019 · 35 comments
Labels
C: Debian/Ubuntu C: Whonix This issue impacts Qubes-Whonix P: critical Priority: critical. Between "major" and "blocker" in severity. r4.0-dom0-stable r4.1-dom0-stable

Comments

@adrelanos
Copy link
Member

adrelanos commented Jul 7, 2019

Reading package lists... Done                                                        
N: Repository 'https://cdn-aws.deb.debian.org/debian buster InRelease' changed its 'Version' value from '' to '10.0'
E: Repository 'https://cdn-aws.deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'testing' to 'stable'
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.
E: Repository 'https://cdn-aws.deb.debian.org/debian-security buster/updates InRelease' changed its 'Suite' value from 'testing' to 'stable'
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.

Affects Debian buster and Whonix 15 templates.

Instructions for users (these work alike for any Debian buster and Whonix users):
https://forums.whonix.org/t/apt-get-error-e-repository-tor-https-cdn-aws-deb-debian-org-debian-security-buster-updates-inrelease-changed-its-suite-value-from-testing-to-stable/7704

Solution for upgrading through QVMM? Dunno.

This would likely be fixed in new template builds without code changes required.

@adrelanos adrelanos added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug labels Jul 7, 2019
@adrelanos adrelanos changed the title apt-get error - E: Repository 'tor+https://cdn-aws.deb.debian.org/debian-security buster/updates InRelease' changed its 'Suite' value from 'testing' to 'stable' apt-get error - E: Repository 'https://cdn-aws.deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'testing' to 'stable' Jul 7, 2019
@andrewdavidwong andrewdavidwong added C: Debian/Ubuntu C: Whonix This issue impacts Qubes-Whonix labels Jul 8, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Jul 8, 2019
@tasket
Copy link

tasket commented Jul 8, 2019

FWIW, I fixed this in one template by changing 'buster' to 'stable' in sources.list, performed one update, then changed sources.list back to 'buster'. But adrelanos' workaround is easier and probably more correct.

@unman
Copy link
Member

unman commented Jul 9, 2019

This really isn't a Qubes issue.

The "easier" way for end users updating manually is to use apt - that's what it's designed to do, get rid of the command line options.
A manual apt update will notice the change and prompt user to accept the change.

The only Qubes relevant part of this is the impact on the updater process, which reports success, but none the less fails. It should be possible to drop a config file in /etc/apt/apt.conf.d in an updated salt package, but that seems like overkill to me.

I'll add a note to the docs, and maybe the FAQ.

@andrewdavidwong
Copy link
Member

The only Qubes relevant part of this is the impact on the updater process, which reports success, but none the less fails.

Shouldn't the Qubes updater be robust against this sort of thing, though?

@tasket
Copy link

tasket commented Jul 10, 2019

Shouldn't the Qubes updater be robust against this sort of thing, though?

Yes, definitely. However, Qubes RPC uses apt-get as does my qubes-multi-update, so users are left with non-updating templates because of pre-release state in the template.

The template in testing is still from June, so I think the Qubes R4.2rc1 release could also have this problem.

The template should be rebuilt or at least updated and then re-issued.

@unman
Copy link
Member

unman commented Jul 10, 2019

Shouldn't the Qubes updater be robust against this sort of thing, though?

No. It isn't a bug, and nor is it an error - neither in Debian nor in Qubes. It's a security mechanism.
We choose to use apt-secure for Debian templates. Apt-secure requires a user to manually accept changes in the repo status - my hope for a config file was misplaced.

The template should be rebuilt or at least updated and then re-issued.

Of course, there isn't a current template available as yet, only testing. And 4.2rc1 does have the testing template, so cant be updated without user intervention.

I've tried to rebuild, but the build server seems to be broken at the moment, which is why we dont have an updated template,( and some packages aren't being pushed from testing to current).
@marmarek knows

@h01ger
Copy link

h01ger commented Jul 10, 2019 via email

@unman
Copy link
Member

unman commented Jul 10, 2019

@h01ger To be picky, that's a feature request isn't it?
The existing treatment is completely in line with the apt-secure documentation.

@h01ger
Copy link

h01ger commented Jul 10, 2019 via email

@unman
Copy link
Member

unman commented Jul 10, 2019

I think we can agree that if Debian introduces that feature we'd incorporate it in to Qubes updater.
Until then, some advice to users.

@tasket
Copy link

tasket commented Jul 10, 2019

Regardless of how Debian devs feel about the severity of the bug, they have the luxury of saying "Well, you installed a pre-release version and have an extra step to get it functioning as a full release".

Qubes doesn't have that option, because it shouldn't be distributing templates that are in a pre-release state.... not unless they come from a testing repo. Qubes shouldn't be foisting an unnecessary transition from pre-release to release onto regular users.

@andrewdavidwong andrewdavidwong added P: critical Priority: critical. Between "major" and "blocker" in severity. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: task labels Jul 11, 2019
@andrewdavidwong
Copy link
Member

andrewdavidwong commented Jul 11, 2019

Ok, so there's some disagreement about whether this is a Debian bug and how we should handle it. @marmarek, I think we need a decision from you about how we'll proceed.

@adrelanos
Copy link
Member Author

adrelanos commented Jul 11, 2019 via email

@marmarek
Copy link
Member

I've created PR adding apt-get update --allow-releaseinfo-change call if any list file for buster still contains Suite: testing. It isn't ideal (that option doesn't specify what change exactly should be allowed), but I don't see a better option there.

The PR applies to salt file update, used by "qubes update" application. It doesn't apply to template update started from qubes-manager. Nor manual apt-get update calls.

@tasket
Copy link

tasket commented Jul 17, 2019

@marmarek I recommend against any permanent disabling of apt integrity checks.

AFAICT simply re-uploading an updated template would have fixed this issue, at least for the next two years until Debian 11 is released.

@marmarek
Copy link
Member

Updated debian-10 templates are already in testing repo. @adrelanos you may want to build new Whonix templates.

@marmarek
Copy link
Member

@adrelanos do you want some automatic update method (like PR I created above)? Or just template rebuild? debian-10 templates are still in testing and already rebuilt. Whonix 15 templates are in stable, so this is more visible to the users.

@adrelanos
Copy link
Member Author

adrelanos commented Jul 20, 2019 via email

@marmarek
Copy link
Member

marmarek commented Aug 1, 2019

@adrelanos When would be a good time for new Whonix template builds?
I'd like to have https://github.com/Whonix/whonixsetup/commit/9c6ec0f503c1b381d0e7cd50e465eb491f58447e there, as it's require for automatic tests to work.

@adrelanos
Copy link
Member Author

That change is not yet in stable-proposed or testers repository since some not so well tested changes in other packages are still being worked on in the developers repository. I am good for development, but don't have a good grip on stable/release management / backporting / Q/A. Due to missing https://phabricator.whonix.org/T709 (or similar) it's hard to keep track on singular changes and/or moving packages though suites faster. Specifically also tb-updater should have stable upgrades faster often.

@adrelanos
Copy link
Member Author

@marmarek:

@adrelanos When would be a good time for new Whonix template builds?

Now would be a good time.

Since #4918 (comment) among other fixes and enhancements hit Whonix stable repository today.

@zaoqi
Copy link

zaoqi commented Oct 27, 2019

This issue was fixed

@andrewdavidwong
Copy link
Member

Closing this as resolved. If you believe the issue is not yet resolved, or if anyone is still affected by this issue, please leave a comment, and we'll be happy to reopen this. Thank you.

marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-update that referenced this issue Sep 16, 2021
apt as released in initial debian-10 template, requires confirming the
repository change from stable to oldstable (which happened with
debian-11 release). Later versions of apt has this fixes, but lets fix
updating from the older version too.

Simply call 'apt-get update --allow-releaseinfo-change' before the
update.

Related to QubesOS/qubes-issues#6624
Fixes QubesOS/qubes-issues#5149 (which was about the very same thing
with previous debian version)
marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-update that referenced this issue Sep 26, 2021
apt as released in initial debian-10 template, requires confirming the
repository change from stable to oldstable (which happened with
debian-11 release). Later versions of apt has this fixes, but lets fix
updating from the older version too.

Simply call 'apt-get update --allow-releaseinfo-change' before the
update.

Related to QubesOS/qubes-issues#6624
Fixes QubesOS/qubes-issues#5149 (which was about the very same thing
with previous debian version)
@qubesos-bot
Copy link

Automated announcement from builder-github

The component mgmt-salt-dom0-update (including package qubes-mgmt-salt-dom0-update-4.1.7-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-update that referenced this issue Oct 11, 2021
apt as released in initial debian-10 template, requires confirming the
repository change from stable to oldstable (which happened with
debian-11 release). Later versions of apt has this fixes, but lets fix
updating from the older version too.

Simply call 'apt-get update --allow-releaseinfo-change' before the
update.

Related to QubesOS/qubes-issues#6624
Fixes QubesOS/qubes-issues#5149 (which was about the very same thing
with previous debian version)

(cherry picked from commit c31289f)
@qubesos-bot
Copy link

Automated announcement from builder-github

The component mgmt-salt-dom0-update (including package qubes-mgmt-salt-dom0-update-4.0.11-1.fc25) has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component mgmt-salt-dom0-update (including package qubes-mgmt-salt-dom0-update-4.1.7-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component mgmt-salt-dom0-update (including package qubes-mgmt-salt-dom0-update-4.0.12-1.fc25) has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Debian/Ubuntu C: Whonix This issue impacts Qubes-Whonix P: critical Priority: critical. Between "major" and "blocker" in severity. r4.0-dom0-stable r4.1-dom0-stable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants